Respect validationMode in React material table cells#2400
Merged
lucas-koehler merged 4 commits intoeclipsesource:masterfrom Dec 5, 2024
Merged
Respect validationMode in React material table cells#2400lucas-koehler merged 4 commits intoeclipsesource:masterfrom
lucas-koehler merged 4 commits intoeclipsesource:masterfrom
Conversation
|
|
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
0mpurdy
commented
Nov 29, 2024
packages/material-renderers/test/renderers/MaterialTableControl.test.tsx
Outdated
Show resolved
Hide resolved
0mpurdy
force-pushed
the
validation-mode-cell-2398
branch
from
811073d to
d8371c2
Compare
Contributor
|
@0mpurdy Thanks for the contribution ❤️ |
0mpurdy
force-pushed
the
validation-mode-cell-2398
branch
from
d8371c2 to
0038727
Compare
lucas-koehler
approved these changes
Dec 5, 2024
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
LGTM now! Thanks for the contribution and all the tests ✨
sdirix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2398