create OneOfEnumCell for select inputs#2414
create OneOfEnumCell for select inputs#2414lucas-koehler merged 6 commits intoeclipsesource:masterfrom
Conversation
❌ Deploy Preview for jsonforms-examples failed.
|
|
Hi @edkahara , thank you for the contribution ❤️ Please note that you need to sign the contributor license agreement (CLA) before we can accept your contribution. See this comment: #2414 (comment) |
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @edkahara ,
Thanks again for the contribution! The code already looks pretty good to me. I just have one tiny suggestion for a comment.
Could you please add some tests for the new renderer? We try to have at least rudimentary unit tests for all renderers. You can use https://github.com/eclipsesource/jsonforms/blob/master/packages/vanilla-renderers/test/renderers/EnumCell.test.tsx as a starting point for this.
|
@lucas-koehler Is there any other change required? |
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @edkahara thanks again for the contribution and adding these extensive tests ❤️
The code now looks good to me!
Building the example app fails here. However, this is not caused by this PR and building and testing it locally worked fine. Thus, we can still merge this :)
Context: https://jsonforms.discourse.group/t/oneof-not-producing-select-field-or-multiple-choice-checklist-in-vanilla-renderers/2574
OneOfEnumCellcell that creates select inputs in vanella-renderers.hideEmptyOptionthat whentrue, removes the empty option so the select input only has the options the user passes inoneOf