Isolate handling of temporal context and metronome - #7
Merged
Conversation
edevoogd
marked this pull request as draft
April 18, 2021 11:23
- Small tweak to ClockQuantizer.PrepareAdvance() in light of quiescing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the more intricate pieces of
ClockQuantizerwere pulled out and wrapped in aTemporalContextDrivershim that abstracts the following items:ISystemClockTemporalContext, if one is providedClockAdjustedandMetronomeTickedeventsISystemClockTemporalContextor if a providedISystemClockTemporalContextdoes not provide a metronome.TemporalContextDriverprovides the "internal" metronome, timer resources are freed up while in quiescent state.TemporalContextDriveris taken out of quiescing stateIAsyncDisposablesupport ofSystem.Threading.Timerbetween TFMsIn order to clean things up a bit more,
bool ISystemClockTemporalContext.ProvidesMetronomewas changed toTimeSpan? ISystemClockTemporalContext.MetronomeIntervalTimeSpan. This allows implementers to not only specify the fact that an external metronome is being provided, but also its interval time-span.