Upgrade mise to require using aube by jayvdb · Pull Request #105 · edge-toolkit/core

jayvdb · 2026-08-03T01:34:32Z

Summary by CodeRabbit

Bug Fixes
- Inference failures are now reported without stopping subsequent detection iterations.
- Status and event timestamps are consistently recorded in UTC.
- Improved npm package resolution for modern workspace and symlink layouts.
Updates
- Updated the WebAssembly runtime to Wasmtime 47.0.3.
- Added workspace support for improved package and dependency management.
Chores
- Enhanced security scanning, coverage workflows, and build disk-space management.
- Updated development tooling and documented setup requirements.

coderabbitai · 2026-08-03T01:34:40Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9a198881-bc8c-431f-b649-fcab8e29be5c

📥 Commits

Reviewing files that changed from the base of the PR and between 5a1467d and 77cf4d0.

📒 Files selected for processing (1)

.github/workflows/docker-linux.yaml

📝 Walkthrough

Walkthrough

The pull request updates pnpm and OSV-Scanner configuration, advances mise and Wasmtime versions, adapts coverage and Windows workflows, models mise npm symlinks in tests, and updates Python service timestamps and inference failure handling.

Changes

Repository tooling and dependency scanning

Layer / File(s)	Summary
Workspace and dependency scanning `.dockerignore`, `.editorconfig`, `.github/workflows/dependencies.yaml`, `.mise/config.toml`, `package.json`, `pnpm-workspace.yaml`, `config/`	Adds pnpm workspace and lockfile handling, separates Rust and npm OSV-Scanner tasks, pins jqfmt, and updates related lint configuration.
Toolchain and coverage alignment `.github/actions/install-mise/action.yaml`, `.mise/config.coverage.toml`, `Cargo.toml`, `Dockerfile`, `README.md`, `CLAUDE.md`, `services/ws-wasi-runner/Cargo.toml`	Updates mise and Wasmtime versions. Coverage tasks support new nightly Cargo layouts and ONNX Runtime paths.

CI and runtime behavior

Layer / File(s)	Summary
Windows build and cleanup flow `.github/actions/free-disk-space-windows/action.yaml`, `.github/workflows/docker-.yaml`, `.mise/config.windows.toml`, `Dockerfile`, `services/ws-server/Dockerfile`	Adds configurable Windows cleanup, standardizes Windows test builds, disables incremental Cargo compilation, and updates Windows container identity handling.
mise npm symlink layout `libs/edge-toolkit/src/config.rs`, `libs/edge-toolkit/tests/npm_mod.rs`, `services/modules/tests/symlinks.rs`	Documents and tests the two-hop mise npm symlink layout through a virtual store.
Python service error and timestamp handling `services/ws-modules/pydata1/`, `services/ws-modules/pyeye1/`, `services/ws-modules/pyface1/*`	Uses UTC timestamps, documents intentional broad exception handling, and tests continued inference iterations after failures.
Lint and container cleanup `services/ws-pyo3-runner/python/`, `ruff.toml`, `Dockerfile`	Uses implicit returns in callback handlers and expands lint exceptions for generated code and Windows-specific commands.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

edge-toolkit/core#77: Both changes extend OSV-Scanner coverage through .mise/config.toml.
edge-toolkit/core#88: Both changes modify WASM coverage configuration in .mise/config.coverage.toml.
edge-toolkit/core#99: Both changes update the pyeye1 workflow and its tests.

Suggested reviewers: pierre-tenedero

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Upgrade mise to require using aube' directly aligns with the pull request's primary objective to upgrade mise version and integrate aube-based npm package management throughout the codebase.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch aube

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

deepsource-io · 2026-08-03T01:34:49Z

DeepSource Code Review

We reviewed changes in cd94cb4...77cf4d0 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene Coverage

Code Review Summary

Analyzer	Updated (UTC)	Details
C#	Aug 4, 2026 8:57a.m.	Review ↗
C & C++	Aug 4, 2026 8:57a.m.	Review ↗
Docker	Aug 4, 2026 8:57a.m.	Review ↗
Java	Aug 4, 2026 8:57a.m.	Review ↗
JavaScript	Aug 4, 2026 8:57a.m.	Review ↗
Python	Aug 4, 2026 8:57a.m.	Review ↗
Rust	Aug 4, 2026 8:57a.m.	Review ↗
Secrets	Aug 4, 2026 8:57a.m.	Review ↗
Code coverage	Aug 4, 2026 9:32a.m.	Review ↗

Code Coverage Summary

Language	Line Coverage (New Code)	Line Coverage (Overall)
Aggregate	83.3%	58.2% [▲ up 0.4% from `main`]
Python	83.3%	89.1% [▲ up 3.8% from `main`]
Rust	-	55.7% [▲ up 0.1% from `main`]

➟ Additional coverage metrics may have been reported. See full coverage report ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

codacy-production · 2026-08-03T01:40:44Z

Not up to standards ⛔

🔴 Issues 3 high · 3 medium

Alerts:
⚠ 6 issues (≤ 0 issues of at least minor severity)

Results:
6 new issues

Category Results

BestPractice 3 medium

ErrorProne 3 high

View in Codacy

🟢 Metrics 13 complexity · -1 duplication

Metric Results

Complexity 13

Duplication -1

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

codecov · 2026-08-03T01:46:14Z

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
services/ws-modules/pydata1/pydata1/__init__.py	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

coderabbitai

🧹 Nitpick comments (1)

services/ws-modules/pyeye1/pyeye1/eye_detection.py (1)
433-433: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Use ISO 8601 for machine-facing detection timestamps.

processed_at is read as a string when the WebSocket Rust consumer logs inference details, so avoid %X for JSON payloads: it omits the date and can be locale-dependent. Use datetime.now(timezone.utc).isoformat(timespec="seconds") for pyeye1.py#L480, pyface1.py#L286, and the corresponding DetectionSummary in face-detection/src/lib.rs. Keep display-only processed at: text explicit if it must stay time-only.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@services/ws-modules/pyeye1/pyeye1/eye_detection.py` at line 433, Replace the
machine-facing processed_at formatting with UTC ISO 8601 timestamps using
seconds precision. Update services/ws-modules/pyeye1/pyeye1/eye_detection.py at
lines 433-433 and 480-480, services/ws-modules/pyface1/pyface1/face_detection.py
at line 286, and the corresponding DetectionSummary in
face-detection/src/lib.rs; retain time-only formatting only for explicitly
display-only “processed at:” text.
Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@services/ws-modules/pyeye1/pyeye1/eye_detection.py`:
- Line 433: Replace the machine-facing processed_at formatting with UTC ISO 8601
timestamps using seconds precision. Update
services/ws-modules/pyeye1/pyeye1/eye_detection.py at lines 433-433 and 480-480,
services/ws-modules/pyface1/pyface1/face_detection.py at line 286, and the
corresponding DetectionSummary in face-detection/src/lib.rs; retain time-only
formatting only for explicitly display-only “processed at:” text.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 663888cf-0bd3-445c-956c-1bfa20213a74

📥 Commits

Reviewing files that changed from the base of the PR and between cd94cb4 and 5a1467d.

⛔ Files ignored due to path filters (3)

Cargo.lock is excluded by !**/*.lock
generated/zig-rest/src/et_rest_client.zig is excluded by !**/generated/**
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (40)

.dockerignore
.editorconfig
.github/actions/free-disk-space-windows/action.yaml
.github/actions/install-mise-tools/action.yaml
.github/actions/install-mise/action.yaml
.github/workflows/dependencies.yaml
.github/workflows/docker-linux.yaml
.github/workflows/docker-windows.yaml
.gitignore
.mise/config.coverage.toml
.mise/config.js.toml
.mise/config.toml
.mise/config.windows.toml
CLAUDE.md
Cargo.toml
Dockerfile
Dockerfile.nanoserver
Dockerfile.windows
README.md
config/ast-grep/rules/doc-summary-ends-with-period.yaml
config/deny.toml
config/dprint.jsonc
config/ls-lint.yaml
config/osv-scanner.toml
config/typos.toml
libs/edge-toolkit/src/config.rs
libs/edge-toolkit/tests/npm_mod.rs
package.json
pnpm-workspace.yaml
ruff.toml
services/modules/tests/symlinks.rs
services/ws-modules/pydata1/pydata1/__init__.py
services/ws-modules/pyeye1/pyeye1/eye_detection.py
services/ws-modules/pyeye1/tests/test_run_workflow.py
services/ws-modules/pyface1/pyface1/face_detection.py
services/ws-modules/pyface1/tests/test_face_detection.py
services/ws-pyo3-runner/python/fanout.py
services/ws-pyo3-runner/python/storage_pingpong.py
services/ws-server/Dockerfile
services/ws-wasi-runner/Cargo.toml

💤 Files with no reviewable changes (4)

.dockerignore
config/osv-scanner.toml
.gitignore
.github/actions/install-mise-tools/action.yaml

Require using aube

48b6b09

jayvdb added 7 commits August 3, 2026 10:20

Fix Rust CVE and ruff errors

f54c818

lints and fixes

9440a53

fixes

b638884

more fixes

3fe9839

force update of mise

12bfe41

fixes

103d76f

fix docker disk space

5a1467d

jayvdb changed the title ~~Require using aube~~ Upgrade mise to require using aube Aug 4, 2026

jayvdb marked this pull request as ready for review August 4, 2026 04:12

coderabbitai Bot reviewed Aug 4, 2026

View reviewed changes

try to fix opensuse

77cf4d0

jayvdb requested a review from pierre-tenedero August 4, 2026 11:09

pierre-tenedero approved these changes Aug 4, 2026

View reviewed changes

jayvdb merged commit d8d42f9 into main Aug 4, 2026
63 of 67 checks passed

jayvdb deleted the aube branch August 4, 2026 11:41

Navigation Menu

Uh oh!

Upgrade mise to require using aube - #105

Upgrade mise to require using aube#105
jayvdb merged 9 commits into
mainfrom
aube

jayvdb commented Aug 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

deepsource-io Bot commented Aug 3, 2026 •

edited

Loading

Uh oh!

codacy-production Bot commented Aug 3, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Aug 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jayvdb commented Aug 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

deepsource-io Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Code Coverage Summary

Uh oh!

codacy-production Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

codecov Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jayvdb commented Aug 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

deepsource-io Bot commented Aug 3, 2026 •

edited

Loading

codacy-production Bot commented Aug 3, 2026 •

edited

Loading

codecov Bot commented Aug 3, 2026 •

edited

Loading