More coverage by jayvdb · Pull Request #86 · edge-toolkit/core

jayvdb · 2026-07-14T20:49:12Z

Summary by CodeRabbit

New Features
- Added reusable TLS support for the WebSocket server, including certificate generation, loading, and server configuration.
- Exposed WebGPU interface trimming for broader tooling use.
Tests
- Added coverage for TLS certificate workflows and WebGPU interface preservation.
- Added registry tests covering reconnections, persistence, missing files, and pending messages.

coderabbitai · 2026-07-14T20:49:21Z

📝 Walkthrough

Walkthrough

The changes add integration tests for agent registry and TLS behavior, expose the WebSocket server’s TLS module and helper APIs, and make the WebGPU WIT trimming helper public with fixture-based validation.

Changes

Agent registry validation

Layer / File(s)	Summary
Registry persistence and record tests `libs/edge-toolkit/tests/registry.rs`	Tests session replacement and lookup, save/load behavior, missing-file handling, and pending direct-message map construction.

WebSocket TLS exposure

Layer / File(s)	Summary
TLS module wiring and validation `services/ws-server/src/lib.rs`, `services/ws-server/src/main.rs`, `services/ws-server/src/tls.rs`, `services/ws-server/tests/tls.rs`, `services/ws-server/Cargo.toml`	Exports and imports the TLS module through the crate, marks TLS helper results as must-use, adds test dependencies, and validates certificate generation, loading, and server configuration.

WebGPU WIT trimming validation

Layer / File(s)	Summary
WIT trimming API and fixture test `utilities/int-gen/src/wit/upstream.rs`, `utilities/int-gen/tests/webgpu_trim.rs`	Makes `strip_webgpu` public and verifies that trimming preserves the WebGPU package and `gpu-device` resource.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: pierre-tenedero

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is too generic and does not describe the specific coverage added in this pull request.	Rename it to mention the main area covered, such as ws-server TLS tests, registry behavior, or WIT trimming coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch a-bit-more

_{Comment @coderabbitai help to get the list of available commands.}

deepsource-io · 2026-07-14T20:49:28Z

DeepSource Code Review

We reviewed changes in 9fd83d3...da34262 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene Coverage

Code Review Summary

Analyzer	Updated (UTC)	Details
C#	Jul 14, 2026 9:19p.m.	Review ↗
C & C++	Jul 14, 2026 9:19p.m.	Review ↗
Docker	Jul 14, 2026 9:19p.m.	Review ↗
Java	Jul 14, 2026 9:19p.m.	Review ↗
JavaScript	Jul 14, 2026 9:19p.m.	Review ↗
Python	Jul 14, 2026 9:19p.m.	Review ↗
Rust	Jul 14, 2026 9:19p.m.	Review ↗
Secrets	Jul 14, 2026 9:19p.m.	Review ↗
Code coverage	Jul 14, 2026 9:41p.m.	Review ↗

Code Coverage Summary

Language	Line Coverage (New Code)	Line Coverage (Overall)
Aggregate	100%	54.8% [▲ up 1.3% from `main`]
Python	-	54.2%
Rust	100%	54.8% [▲ up 1.3% from `main`]

➟ Additional coverage metrics may have been reported. See full coverage report ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

codacy-production · 2026-07-14T20:50:27Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results

Complexity 0

Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

codecov · 2026-07-14T21:11:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codacy-production

Pull Request Overview

This PR successfully increases test coverage for registry persistence, TLS management, and WIT file processing, with all primary acceptance criteria addressed through implemented test scenarios. Codacy reports that the changes are up to standards with no new quality issues.

There is a medium-severity concern regarding a misleading function signature in utilities/int-gen/src/wit/upstream.rs that should be addressed to reduce caller complexity. Additionally, while the tests are functional, the use of hardcoded relative paths in the WebGPU fixture tests may lead to instability in certain CI environments.

About this PR

This PR lacks a description. Providing context on the coverage goals and the specific scenarios being addressed is necessary for long-term maintainability and tracking.

Test suggestions

AgentRegistry save/load round-trip and session persistence check
AgentRegistry reconnection and session lookup logic
AgentRegistry loading from a missing file
TLS certificate generation, disk storage, and rustls configuration build
WIT trimming logic verification against a real fixture

Low confidence findings

The test 'strips_webgpu_wit_and_reemits_the_package' uses a hardcoded path to a file in the 'generated/' directory. This may cause failures in restricted CI environments or if the execution context changes. Consider using a more robust method to locate test fixtures.

_{TIP Improve review quality by adding custom instructions}
_{TIP How was this review? Give us feedback}

codacy-production · 2026-07-14T22:48:28Z

+    reason = "inputs are trusted (upstream WIT or the committed fixture); a parse failure is a bug, so unwrap"
 )]
-fn strip_webgpu(raw: &str) -> Result<String, Error> {
+pub fn strip_webgpu(raw: &str) -> Result<String, Error> {


_{🟡 MEDIUM RISK}

Suggestion: The function signature is misleading because it never returns an Err. All parsing and encoding failures are handled by panicking, so wrapping the result in a Result adds unnecessary complexity for callers.

Try running the following prompt in your coding agent:

Simplify strip_webgpu in utilities/int-gen/src/wit/upstream.rs to return String instead of Result<String, Error>, update the return statement at the end of the function to remove the Ok() wrapper, and remove the clippy::unwrap_in_result expectation from the function's attribute block.

coderabbitai

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@libs/edge-toolkit/tests/registry.rs`:
- Around line 45-50: Update agent_record_with_pending_builder_replaces_the_map
to initialize a non-empty pending-message map, replace it with a distinct
non-empty map through with_pending_direct_messages, and assert
pending_direct_messages exactly matches the replacement map. Ensure the test
would fail if the builder ignores its argument or retains the original map.
- Around line 33-38: Update the persistence test around AgentRegistry::load so
it first verifies the reloaded registry contains the agent’s persisted record
using the available record lookup API, or serialized YAML when no lookup exists.
Keep the existing agent_session assertion separately to confirm sessions remain
unpersisted.

In `@utilities/int-gen/tests/webgpu_trim.rs`:
- Around line 17-25: Add a negative assertion in the strip_webgpu test after
producing out, checking that a known declaration or method from
WEBGPU_DROP_METHODS present in the fixture is absent from the trimmed output.
Keep the existing assertions for retained package and resource content
unchanged, and use the known dropped member rather than an arbitrary string.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b1412a61-a4e1-41f2-89ad-393216ac07b2

📥 Commits

Reviewing files that changed from the base of the PR and between 9fd83d3 and da34262.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (8)

libs/edge-toolkit/tests/registry.rs
services/ws-server/Cargo.toml
services/ws-server/src/lib.rs
services/ws-server/src/main.rs
services/ws-server/src/tls.rs
services/ws-server/tests/tls.rs
utilities/int-gen/src/wit/upstream.rs
utilities/int-gen/tests/webgpu_trim.rs

coderabbitai · 2026-07-14T22:51:09Z

+    // Persist and reload. Sessions are #[serde(skip)], so they return as None, but the agent survives.
+    let dir = tempdir().unwrap();
+    let path = dir.path().join("registry.yaml");
+    registry.save(&path).unwrap();
+    let reloaded = AgentRegistry::<String>::load(&path).unwrap();
+    assert_eq!(reloaded.agent_session(&agent_id), None, "sessions are not persisted");


🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the reload assertion prove that the record was persisted.

reloaded.agent_session(&agent_id) == None is also true for an entirely empty registry, so this does not verify that the agent survived the save/load round trip. Assert a persisted field through the registry's record lookup API, or inspect the serialized YAML if no such API exists; keep the session assertion separately.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@libs/edge-toolkit/tests/registry.rs` around lines 33 - 38, Update the persistence test around AgentRegistry::load so it first verifies the reloaded registry contains the agent’s persisted record using the available record lookup API, or serialized YAML when no lookup exists. Keep the existing agent_session assertion separately to confirm sessions remain unpersisted.

coderabbitai · 2026-07-14T22:51:09Z

+#[test]
+fn agent_record_with_pending_builder_replaces_the_map() {
+    let record = AgentRecord::<String>::new(AgentConnectionState::Disconnected, None, None)
+        .with_pending_direct_messages(BTreeMap::new());
+    assert!(record.pending_direct_messages.is_empty());
+}


🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Exercise replacement with a non-empty pending-message map.

The newly constructed record and the replacement map are both empty, so this test passes even if with_pending_direct_messages ignores its argument or fails to replace an existing map. Seed a non-empty map, then replace it with a distinct map and assert the exact result.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@libs/edge-toolkit/tests/registry.rs` around lines 45 - 50, Update agent_record_with_pending_builder_replaces_the_map to initialize a non-empty pending-message map, replace it with a distinct non-empty map through with_pending_direct_messages, and assert pending_direct_messages exactly matches the replacement map. Ensure the test would fail if the builder ignores its argument or retains the original map.

coderabbitai · 2026-07-14T22:51:09Z

+    let out = strip_webgpu(&raw).unwrap();
+    assert!(
+        out.contains("package wasi:webgpu"),
+        "re-emitted WIT should still declare the wasi:webgpu package, got:\n{out}"
+    );
+    // The trimmer keeps the compute resources (e.g. gpu-device) while dropping cross-package glue.
+    assert!(
+        out.contains("resource gpu-device"),
+        "expected the gpu-device resource to survive, got:\n{out}"


🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Assert that trimming removes an unwanted declaration.

These assertions only verify retained content, so a no-op implementation could still pass. Add a negative assertion for a known member from WEBGPU_DROP_METHODS that exists in the fixture but must be absent from out.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@utilities/int-gen/tests/webgpu_trim.rs` around lines 17 - 25, Add a negative assertion in the strip_webgpu test after producing out, checking that a known declaration or method from WEBGPU_DROP_METHODS present in the fixture is absent from the trimmed output. Keep the existing assertions for retained package and resource content unchanged, and use the known dropped member rather than an arbitrary string.

More coverage

82ed051

fix ep

da34262

jayvdb marked this pull request as ready for review July 14, 2026 22:47

jayvdb requested a review from pierre-tenedero July 14, 2026 22:47

codacy-production Bot reviewed Jul 14, 2026

View reviewed changes

coderabbitai Bot reviewed Jul 14, 2026

View reviewed changes

pierre-tenedero approved these changes Jul 15, 2026

View reviewed changes

jayvdb merged commit f885b49 into main Jul 15, 2026
36 of 40 checks passed

jayvdb deleted the a-bit-more branch July 15, 2026 01:32

coderabbitai Bot mentioned this pull request Jul 22, 2026

General tidy up #101

Merged

Navigation Menu

Uh oh!

More coverage - #86

More coverage#86
jayvdb merged 2 commits into
mainfrom
a-bit-more

jayvdb commented Jul 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 14, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 inconclusive)

Uh oh!

deepsource-io Bot commented Jul 14, 2026 •

edited

Loading

Uh oh!

codacy-production Bot commented Jul 14, 2026

Uh oh!

codecov Bot commented Jul 14, 2026 •

edited

Loading

Uh oh!

codacy-production Bot left a comment

Uh oh!

codacy-production Bot Jul 14, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jul 14, 2026

Uh oh!

coderabbitai Bot Jul 14, 2026

Uh oh!

coderabbitai Bot Jul 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jayvdb commented Jul 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 inconclusive)

Uh oh!

deepsource-io Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Code Coverage Summary

Uh oh!

codacy-production Bot commented Jul 14, 2026

Up to standards ✅

Uh oh!

codecov Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codacy-production Bot left a comment

Choose a reason for hiding this comment

Pull Request Overview

About this PR

Test suggestions

Uh oh!

codacy-production Bot Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jayvdb commented Jul 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 14, 2026 •

edited

Loading

deepsource-io Bot commented Jul 14, 2026 •

edited

Loading

codecov Bot commented Jul 14, 2026 •

edited

Loading