Skip to content

treewide: auto-set GPU runtime class on pods requiring GPUs#2225

Merged
charludo merged 2 commits intomainfrom
ch/auto-set-gpu-runtimeclass
Mar 16, 2026
Merged

treewide: auto-set GPU runtime class on pods requiring GPUs#2225
charludo merged 2 commits intomainfrom
ch/auto-set-gpu-runtimeclass

Conversation

@charludo
Copy link
Copy Markdown
Collaborator

@charludo charludo commented Mar 4, 2026

@katexochen @burgerdev you both had very different opinions on this, so this is more of a draft/suggestion.

The critical questions here are

  • is PodSpecRequiresGPU accurate enough?
  • should this behavior be toggleable by a generate flag?

@charludo charludo requested review from burgerdev and katexochen March 4, 2026 11:20
@charludo charludo force-pushed the ch/auto-set-gpu-runtimeclass branch 2 times, most recently from 95207f2 to 314227a Compare March 4, 2026 18:26
@charludo charludo added the feature Shiny new feature for our users label Mar 10, 2026
@charludo charludo marked this pull request as ready for review March 10, 2026 10:15
burgerdev
burgerdev reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, please add docs.

@charludo charludo force-pushed the ch/auto-set-gpu-runtimeclass branch from 314227a to c6f80cc Compare March 11, 2026 12:25
@charludo charludo requested a review from burgerdev March 11, 2026 12:25
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 11, 2026 •
edited
Loading

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-16 09:06 UTC

@charludo charludo force-pushed the ch/auto-set-gpu-runtimeclass branch from c6f80cc to d60defd Compare March 11, 2026 13:45
@charludo charludo force-pushed the ch/auto-set-gpu-runtimeclass branch from d60defd to bbe282b Compare March 11, 2026 13:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 11, 2026 •
edited by charludo
Loading

Do the documentation changes need to be backported?

Changes to /docs/docs won't be visible until the next release.
If you are fixing something in the docs that should be immediately visible, the changes needs to be made to both /docs/docs and /docs/versioned_docs/version-X.Y, where X.Y is the version of the latest minor release.
This can be done in this same PR.

  • Yes, this should be backported to the current version of the docs.
  • No, the PR only contains docs changes relevant for future versions.

burgerdev
burgerdev approved these changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charludo charludo merged commit 51f4858 into main Mar 16, 2026
15 of 16 checks passed
@charludo charludo deleted the ch/auto-set-gpu-runtimeclass branch March 16, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burgerdev burgerdev burgerdev approved these changes

@katexochen katexochen Awaiting requested review from katexochen

Assignees

No one assigned

Labels

feature Shiny new feature for our users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charludo @burgerdev