fix: Fully replace pipelines on Writable.Pipeline update#1748
Open
jesson1 wants to merge 1 commit intoedgexfoundry:mainfrom
Open
fix: Fully replace pipelines on Writable.Pipeline update#1748jesson1 wants to merge 1 commit intoedgexfoundry:mainfrom
jesson1 wants to merge 1 commit intoedgexfoundry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1748 +/- ##
==========================================
- Coverage 43.41% 43.23% -0.19%
==========================================
Files 64 64
Lines 4959 4980 +21
==========================================
Hits 2153 2153
- Misses 2663 2684 +21
Partials 143 143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2a716a1 to
b704129
Compare
judehung
reviewed
Oct 31, 2025
Previously only updated topics/transforms per pipeline ID. Now perform full replacement: remove pipelines not in config (unregister metrics), create/register new pipelines, and build full topics with base prefix. Signed-off-by: jiasheng.yu <jiashengyu@deepglint.com>
b704129 to
26d5ce6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Writable.Pipeline is updated, the runtime previously only updated topics/transforms per pipeline ID. This PR changes the update to a full replacement: pipelines absent from the new config are removed (and their metrics unregistered) and new pipelines are created and registered. Incoming topics are expanded with the message-bus base prefix.
What changed
UpdateFunctionsPipelines(...).UpdateFunctionsPipelines:FunctionPipelineinstances and registers their metrics.If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)