Skip to content

Added another format for registration field options #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariajgrimaldi merged 1 commit into from
Feb 3, 2021
Merged

Added another format for registration field options #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion openedx/core/djangoapps/user_authn/views/registration_form.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,10 @@ def _add_custom_field(self, form_desc, required=True, **kwargs):
# Check to convert options:
field_options = custom_field_dict.get("options")
if field_options:
field_options = [(six.text_type(option.lower()), option) for option in field_options]
try:
field_options = [(six.text_type(value.lower()), name) for value, name in field_options.items()]

@morenol morenol Feb 2, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think that we should try first the old format (field_options = [(six.text_type(value.lower()), value) for value in field_options]) and if that fails use the new format. What do you think?

@mariajgrimaldi mariajgrimaldi Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how the old format would fail? 🤔

@morenol morenol Feb 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. My bad😂

except AttributeError:
field_options = [(six.text_type(value.lower()), value) for value in field_options]

# Set default option if applies:
default_option = custom_field_dict.get("default")
Expand Down