JU-6: add support for openedx-events - #567
Merged
Merged
Conversation
mariajgrimaldi
changed the base branch from
master
to
edunext/limonero.master
October 28, 2021 17:01
mariajgrimaldi
changed the base branch from
edunext/limonero.master
to
li/ednx/JU-6
October 28, 2021 17:02
mariajgrimaldi
force-pushed
the
li/ednx/JU-6
branch
from
November 2, 2021 13:58
405dc0e to
ec206aa
Compare
mariajgrimaldi
force-pushed
the
li/ednx/JU-6_P2
branch
from
November 2, 2021 14:00
7207373 to
d500cd4
Compare
mariajgrimaldi
force-pushed
the
li/ednx/JU-6_P2
branch
from
November 2, 2021 19:47
d500cd4 to
31f5ceb
Compare
mariajgrimaldi
requested review from
MaferMazu,
MoisesGSalas,
jignaciopm and
magajh
November 2, 2021 19:57
mariajgrimaldi
commented
Nov 2, 2021
Member
|
@mariajgrimaldi How much does this differ from the upstream code? Where did you have to make adjustments if any? |
Contributor
Author
|
Good question, @MoisesGSalas. Thanks.
The rest is the same:
|
mariajgrimaldi
force-pushed
the
li/ednx/JU-6
branch
3 times, most recently
from
November 3, 2021 22:08
4abfc60 to
74ee7ac
Compare
mariajgrimaldi
force-pushed
the
li/ednx/JU-6_P2
branch
from
November 3, 2021 22:13
6df8bbd to
4fd9486
Compare
mariajgrimaldi
changed the base branch from
li/ednx/JU-6
to
edunext/limonero.master
November 4, 2021 13:26
mariajgrimaldi
force-pushed
the
li/ednx/JU-6_P2
branch
from
November 4, 2021 13:26
4fd9486 to
b6246c1
Compare
MoisesGSalas
approved these changes
Nov 4, 2021
felipemontoya
approved these changes
Nov 4, 2021
MaferMazu
approved these changes
Nov 4, 2021
* Add STUDENT_REGISTRATION_COMPLETED event after the user's registration * Add SESSION_LOGIN_COMPLETED event after the user's login session * Add COURSE_ENROLLMENT_CREATED event after the user's enrollment creation * Add COURSE_ENROLLMENT_CHANGED: sent after the enrollment update * Add COURSE_UNENROLLMENT_COMPLETED: sent after the user's unenrollment * Add CERTIFICATE_CREATED after the user's certificate generation has been completed * Add CERTIFICATE_CHANGED: after the certification update has been completed * Add CERTIFICATE_REVOKED: after the certificate revocation has been completed * Add COHORT_MEMBERSHIP_CHANGED: when a cohort membership update ends
mariajgrimaldi
force-pushed
the
li/ednx/JU-6_P2
branch
from
November 5, 2021 16:15
b6246c1 to
0a34a16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Open edX Events in Limonero. These events are part of the OEP-50: Hooks Extension Framework implementation plan.
Since the OEP-50 publication, there has been a lot of discussion surrounding the design of this new extension point; I'll address some here for context:
OpenEdxPublicSignal-a subclass of Django signals- is used to create each event.send_eventis the method that replacessendandsend_robust.STUDENT_REGISTRATION_COMPLETEDis sent after the user's registration.For an overall understanding of the design, check out the Open edX Events ADRs and discussions:
Supporting information
Discuss on Hooks Extension Framework:
https://discuss.openedx.org/t/configuration-for-the-hooks-extension-framework/4527/
Testing instructions
pip install openedx-events==0.6.0