JSB/JU 10, token duration ends in a year. - #595
Merged
Conversation
black-redoc
requested review from
JuanDavidBuitrago,
MaferMazu,
johanseto,
magajh and
mariajgrimaldi
December 9, 2021 18:55
| date_field = Date() | ||
| StudentFieldOverride = apps.get_model('courseware', 'StudentFieldOverride') | ||
| log = logging.getLogger(__name__) | ||
| # log = logging.getLogger(__name__) |
Contributor
There was a problem hiding this comment.
why don't we remove this?
black-redoc
force-pushed
the
JSB/JU-10
branch
from
December 9, 2021 20:34
fffe1cf to
10c1da3
Compare
MaferMazu
reviewed
Dec 9, 2021
| user=override.student) | ||
| except Exception: # pylint: disable=broad-except | ||
| log.exception("migrating %d %r: %r", override.id, override.location, override.value) | ||
| pass |
Contributor
There was a problem hiding this comment.
I would leave this comment:
# The following line is commented since these logs only add noise to output console
# Thi migration only works with IDDE
# log.exception("migrating %d %r: %r", override.id, override.location, override.value)
From: cb57dec
black-redoc
force-pushed
the
JSB/JU-10
branch
from
December 9, 2021 21:05
10c1da3 to
498c26e
Compare
|
|
||
| import json | ||
| import logging | ||
| # import logging |
Contributor
There was a problem hiding this comment.
Can we remove this?
Making the oauth2 tokens with grant client_credentials live for one year refactor: deleted unnecesary comments refactor: replaced comments above of exception section refactor: deleted unnecesary import comment
black-redoc
force-pushed
the
JSB/JU-10
branch
from
December 13, 2021 14:25
498c26e to
412bb07
Compare
mariajgrimaldi
approved these changes
Dec 13, 2021
MaferMazu
approved these changes
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description:
This PR makes the token duration ends in a year.
commits during migration:
issue on JIRA
how to test:
In your terminal paste this curl script, if you have another tenant change these, then write yours
Then you have to obtain a result like this
{ "access_token": "7wjnmhIHC3B67EvNDVD0xo68kwVQJy", "expires_in": 31557600, "token_type": "Bearer", "scope": "read write email profile" }