feat: add first batch of Open edX Filters - #647
Merged
Conversation
* Add PreEnrollmentFilter * Add PreRegisterFilter * Add PreLoginFilter (cherry picked from commit f29a4ee)
mariajgrimaldi
force-pushed
the
MJG/backport-1st-filters-batch
branch
from
May 10, 2022 21:41
c88b7ee to
8379307
Compare
JuanDavidBuitrago
approved these changes
May 12, 2022
JuanDavidBuitrago
left a comment
JuanDavidBuitrago
left a comment
Contributor
There was a problem hiding this comment.
I test StudentRegistrationRequested with PreventRegistration and it is working
Contributor
|
We test it in Stage: Those filters are running |
mariajgrimaldi
force-pushed
the
MJG/backport-1st-filters-batch
branch
from
May 23, 2022 23:10
31929df to
530bf98
Compare
Ian2012
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports the 1st filters batch
(cherry picked from commit f29a4ee)
Supporting information
Upstream PR openedx/openedx-platform#29449
Testing instructions
Review upstream PR
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
After merging this, one of our private plugins that use openedx-events must be updated.