Skip to content

feat: add lms setting to set mfe config cache #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alec4r merged 3 commits into from
May 20, 2022
Merged

feat: add lms setting to set mfe config cache #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
980f183
feat: add lms setting to set mfe config cache
Alec4r May 20, 2022
3a856e6
fix: solve missing imports
Alec4r May 20, 2022
d741b76
fix: only set cache timeout with settings
MaferMazu May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lms/envs/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4872,6 +4872,12 @@ def _make_locale_paths(settings): # pylint: disable=missing-function-docstring
ENABLE_AUTHN_LOGIN_BLOCK_HIBP_POLICY = False
HIBP_LOGIN_BLOCK_PASSWORD_FREQUENCY_THRESHOLD = 5

# .. setting_name: MFE_CONFIG_API_CACHE_TIMEOUT
# .. setting_default: 60*5
# .. setting_description: The MFE_CONFIG site configuration will be cached during the
# specified time
MFE_CONFIG_API_CACHE_TIMEOUT = 60*5

############### Settings for the ace_common plugin #################
ACE_ENABLED_CHANNELS = ['django_email']
ACE_ENABLED_POLICIES = ['bulk_email_optout']
Expand Down
5 changes: 5 additions & 0 deletions openedx/core/djangoapps/mfe_api/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
from django.conf import settings
from django.utils.decorators import method_decorator
from django.views.decorators.cache import cache_page

from rest_framework.response import Response
from rest_framework.views import APIView

Expand All @@ -9,6 +13,7 @@ class MFEConfigView(APIView):
Provides an API endpoint for MFE config from site configurations.
"""

@method_decorator(cache_page(settings.MFE_CONFIG_API_CACHE_TIMEOUT))
def get(self, request):
"""
GET /api/mfe/v1/config
Expand Down