Allow theme template block override - #31
Closed
dfrojas wants to merge 1 commit into
Closed
Conversation
Squirrel18
pushed a commit
that referenced
this pull request
Jun 22, 2018
Member
|
This is outdated |
AuraAlba
pushed a commit
that referenced
this pull request
Oct 30, 2020
Apply XSS security patch and fix issue caused by xss fix in video transcript settings
DeimerM
pushed a commit
that referenced
this pull request
Jul 23, 2024
feat: this changes the current phone number regex to allow the plus s…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a feature already added in master upstream that allows overriding a template block. This is the PR already merged in master: https://github.com/edx/edx-platform/pull/15947. We need to add it to our ginkgo master.
How to test (textually from original PR)
make a directory /edx/app/edxapp/themes/testtheme
create a template at /edx/app/edxapp/themes/testtheme/lms/templates/dashboard.html, and put this content into it:
If you want, you could add other blocks like
<%block name="bodyextra">Overriden Body Extra!</%block>After you restart the LMS, you should be able to see "Overriddden Title!" used as the page title on the student dashboard, if the patch is working correctly.
Maybe you need delete cache:
rm -rf /tmp/mako_*sudo service memcached restart.Reviewers