Skip to content

Allow theme template block override - #31

Closed
dfrojas wants to merge 1 commit into
open-release/ginkgo.masterfrom
dro/template-override
Closed

Allow theme template block override#31
dfrojas wants to merge 1 commit into
open-release/ginkgo.masterfrom
dro/template-override

Conversation

@dfrojas

@dfrojas dfrojas commented Feb 22, 2018

Copy link
Copy Markdown

Description

This PR is a feature already added in master upstream that allows overriding a template block. This is the PR already merged in master: https://github.com/edx/edx-platform/pull/15947. We need to add it to our ginkgo master.

How to test (textually from original PR)

  1. Create a test theme:
  • make a directory /edx/app/edxapp/themes/testtheme

  • create a template at /edx/app/edxapp/themes/testtheme/lms/templates/dashboard.html, and put this content into it:

<%inherit file="dashboard.html" />
<%block name="pagetitle">Overridden Title!</%block>
${parent.body()}

If you want, you could add other blocks like <%block name="bodyextra">Overriden Body Extra!</%block>

  1. In devstatck settings:
COMPREHENSIVE_THEME_DIRS: ["/edx/app/edxapp/themes"]
ENABLE_COMPREHENSIVE_THEMING: true
DEFAULT_SITE_THEME: "testtheme"

After you restart the LMS, you should be able to see "Overriddden Title!" used as the page title on the student dashboard, if the patch is working correctly.

Maybe you need delete cache:
rm -rf /tmp/mako_*
sudo service memcached restart.

Reviewers

Squirrel18 pushed a commit that referenced this pull request Jun 22, 2018
@felipemontoya

Copy link
Copy Markdown
Member

This is outdated

@felipemontoya
felipemontoya deleted the dro/template-override branch February 11, 2020 23:06
AuraAlba pushed a commit that referenced this pull request Oct 30, 2020
Apply XSS security patch and fix issue caused by xss fix in video transcript settings
DeimerM pushed a commit that referenced this pull request Jul 23, 2024
feat: this changes the current phone number regex to allow the plus s…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants