feat: add example for AccountSettingsRenderStarted filter - #1
Merged
mariajgrimaldi merged 4 commits intoMar 6, 2023
Merged
Conversation
This was referenced Dec 5, 2022
| """ | ||
| Pipeline step that stop access to account settings page. | ||
| """ | ||
| raise CourseAboutRenderStarted.RedirectToPage( |
Collaborator
There was a problem hiding this comment.
why CourseAboutRenderStarted if the filter is called StopAccountSettingsRender?
Contributor
Author
There was a problem hiding this comment.
That's my bad, i just fixed it
Contributor
Author
|
Hello @mariajgrimaldi, Can you look at this changes? |
mariajgrimaldi
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add an example for AccountSettingsRenderStarted filter.
This filter's PR is open in: openedx/openedx-filters#46
The hook in edx-platform is open in: openedx/openedx-platform#31295