Skip to content

perf: remove setup command and set user home as TVM_PATH #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alec4r merged 1 commit into from
May 18, 2022
Merged

perf: remove setup command and set user home as TVM_PATH #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ def test_should_return_all_tvm_cli_commands():
assert ' install ' in result.output
assert ' uninstall ' in result.output
assert ' list ' in result.output
assert ' setup ' in result.output
assert ' use ' in result.output
assert ' pip ' in result.output
assert ' plugins ' in result.output


def test_should_fail_if_format_version_is_not_valid():
Expand Down
47 changes: 11 additions & 36 deletions tvm/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from tvm.templates.tutor_switcher import TUTOR_SWITCHER_TEMPLATE

VERSIONS_URL = "https://api.github.com/repos/overhangio/tutor/tags"
TVM_PATH = pathlib.Path().resolve() / '.tvm'
TVM_PATH = pathlib.Path.home() / '.tvm'


def main() -> None:
Expand Down Expand Up @@ -96,6 +96,16 @@ def setup_tvm():
with open(info_file_path, 'w', encoding='utf-8') as info_file:
json.dump(data, info_file, indent=4)

set_switch_from_file()

tutor_switcher = f'{TVM_PATH}/tutor_switcher'
try:
os.symlink(tutor_switcher, '/usr/local/bin/tutor')
except PermissionError:
subprocess.call(['sudo', 'ln', '-s', tutor_switcher, '/usr/local/bin/tutor'])
except FileExistsError:
pass


@click.command(name="list")
@click.option('-l', '--limit', default=10, help='number of `latest versions` to list')
Expand Down Expand Up @@ -246,40 +256,6 @@ def set_switch_from_file() -> None:
os.chmod(switcher_file, stat.S_IRWXU | stat.S_IRWXG | stat.S_IROTH | stat.S_IXOTH)


def install_venv() -> None:
"""Make the switcher file available to the virtualenv path."""
# link from the venv
venv_tutor = pathlib.Path(sys.executable).parent.joinpath('tutor').resolve()
try:
os.symlink(f'{TVM_PATH}/tutor_switcher', venv_tutor)
except FileExistsError:
pass
except PermissionError:
click.echo(
click.style('To set up tvm local is necessary that tvm had been installed in a virtualenv.', fg='red'))
else:
click.echo(click.style(
'Re-activate your virtualenv for changes to take effect', fg='yellow'))


@click.command(name="setup")
@click.option('-g', '--global', 'make_global', is_flag=True, help='Make the tutor command available to the cli')
def install_global(make_global) -> None:
"""Make the switcher file to anyone in the system."""
setup_tvm()
set_switch_from_file()

if not make_global:
install_venv()
else:
try:
os.symlink(f'{TVM_PATH}/tutor_switcher', '/usr/local/bin/tutor')
except PermissionError:
subprocess.call(['sudo', 'ln', '-s', f'{TVM_PATH}/tutor_switcher', '/usr/local/bin/tutor'])
except FileExistsError:
click.echo('There is already a file at: /usr/local/bin/tutor')


@click.command(name="use")
@click.argument('version', callback=validate_version_installed, type=TutorVersionType())
def use(version: str):
Expand Down Expand Up @@ -363,7 +339,6 @@ def list_plugins():
cli.add_command(install)
cli.add_command(uninstall)
cli.add_command(use)
cli.add_command(install_global)
cli.add_command(pip)
cli.add_command(plugins)
plugins.add_command(list_plugins)