Skip to content
This repository was archived by the owner on Jan 27, 2023. It is now read-only.

The test_register_and_select_course test is flaky. - #242

Merged
feanil merged 1 commit into
masterfrom
feanil/remove_flaky_test
Feb 1, 2018
Merged

The test_register_and_select_course test is flaky.#242
feanil merged 1 commit into
masterfrom
feanil/remove_flaky_test

Conversation

@feanil

@feanil feanil commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

This test was run on the staging system twice. The first time it failed. The second time it succeeded.
Failure: https://build.testeng.edx.org/job/microsites-staging-tests/1284/
Success: https://build.testeng.edx.org/job/microsites-staging-tests/1285/

This test was run on the staging system twice.  The first time it failed.  The second time it succeeded.
Failure: https://build.testeng.edx.org/job/microsites-staging-tests/1284/
Success:  https://build.testeng.edx.org/job/microsites-staging-tests/1285/
@feanil

feanil commented Feb 1, 2018

Copy link
Copy Markdown
Contributor Author

jenkins run e2e

@kashifch

kashifch commented Feb 1, 2018 via email

Copy link
Copy Markdown
Contributor

@feanil

feanil commented Feb 1, 2018

Copy link
Copy Markdown
Contributor Author

@kashifch When the fixes merge, feel free to add the tests back. In the meantime, this is slowing down the release so I think it should be removed until it is reliable.

@kashifch

kashifch commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

sure go ahead and remove the test but again this is not specific to this test, next time it can happen on any other test

@kashifch

kashifch commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

here is chrome pr, i will run it 5-6 times and if it pass I think we can try it

#243

if it still fails, I will remove the test

@feanil

feanil commented Feb 1, 2018

Copy link
Copy Markdown
Contributor Author

@kashifch that sounds good, if we can land that instead, I'm fine with that. I'll review that PR and we can try to land it today if possible.

@kashifch

kashifch commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

@feanil @tuchfarber on second thought just remove the test. I thinK it will try the chrome solution for at least 15-20 times before merging

@feanil

feanil commented Feb 1, 2018

Copy link
Copy Markdown
Contributor Author

sounds good. I'll merge once I get a green e2e test build.

@kashifch

kashifch commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

So it might extends to tomorrow, meanwhile removing this test could lessen the strain. If chrome test works out I will include it again

@feanil
feanil merged commit 24edd9d into master Feb 1, 2018
@feanil
feanil deleted the feanil/remove_flaky_test branch February 1, 2018 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants