fix: upgrade ora2 dependency to version 6.17.2 and remove loremipsum d… - #307
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the bundled Open Response Assessment XBlock dependency to avoid the removed loremipsum transitive dependency and address the translation extraction workflow failure.
Changes:
- Raises
ora2minimum version in bundled requirements input. - Updates the base compiled requirement from
ora2==6.16.4toora2==7.0.0. - Removes
loremipsumfrom the base compiled requirements.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
requirements/edx/bundled.in |
Raises the bundled ora2 requirement floor to 7.0.0. |
requirements/edx/base.txt |
Updates the compiled base lockfile for ora2 and removes loremipsum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alenkadev
changed the title
|
Also, if you could include a link to the upstream PR in your PR description, that would be great! |
| optimizely-sdk==5.2.0 | ||
| # via -r requirements/edx/bundled.in | ||
| ora2==6.16.4 | ||
| ora2==6.17.2 |
There was a problem hiding this comment.
Hm. Copilot is right that bundle.in is included in base.in, but I assume that the override here is good enough, especially because this is how the requirements are written in openedx/edx-platform.
If this doesn't fix it and we still run into issues, we could consider addressing this issue and contributing the change upstream.
There was a problem hiding this comment.
Thanks for catching this. bundled.in is included via base.in, so I agree there is a theoretical possibility of future resolves selecting a different version. However, this override pattern matches the current approach used in upstream edx-platform, and the explicit pin in base.txt ensures the compiled requirements use ora2==6.17.2. Given that, I'd prefer to keep this aligned with upstream for now and revisit updating the source constraint if we continue to see dependency resolution issues.
sure, I will do that! |
| optimizely-sdk==5.2.0 | ||
| # via -r requirements/edx/bundled.in | ||
| ora2==6.16.4 | ||
| ora2==6.17.2 |
There was a problem hiding this comment.
Hm. Copilot is right that bundle.in is included in base.in, but I assume that the override here is good enough, especially because this is how the requirements are written in openedx/edx-platform.
If this doesn't fix it and we still run into issues, we could consider addressing this issue and contributing the change upstream.
Description
This PR upgrades the
ora2(Open Response Assessment) XBlock from version 6.16.4 to 6.17.2 which matches the upstream-PR, which removes theloremipsumdependency. This change fixes theModuleNotFoundError: No module named 'pkg_resources'error that was occurring in the translation extraction GitHub Actions workflow.Root Cause:
The older version of ora2 (6.16.4) depended on
loremipsum==1.0.5, which importspkg_resourcesfromsetuptoolsduring its build/installation process. When the CI workflow attempted to install dependencies withoutsetuptoolsbeing explicitly installed first, the build would fail.Changes:
requirements/edx/base.txt: Upgradedora2==6.16.4toora2==6.17.2loremipsum==1.0.5fromrequirements/edx/base.txt(no longer needed)jira link: https://2u-internal.atlassian.net/browse/AU-2810