fix: keep internal consistency with glob and paths

[wkillerud]

Windows paths threw a spanner in the works. This might not be the
optimal solution for outside modules, in which case I'm open to
changing the behavior to maintain win32 style paths on that OS.
The reasoning here is to keep in line with glob (which recommends
only using forward slashes in patterns) and the URLs which end up
on the Eik server (which, being HTTP URLs, use forward slash).

This should hopefully fix an issue Windows users have with the Eik
CLI not finding the files configured in eik.json

[wkillerud]

It's getting late on a Friday. I'll pick this up later.

[trygve-lie]

Is the problem here that we get wrong separator on Windows which does not match with "URL" path separators? Not sure I 100% understand the issue.

Though; Glob support returning a POSIX separator independent of the underlying OS by setting posix as an config.

posix Set to true to use / as the path separator in returned results. On posix systems, this has no effect. On Windows systems, this will return / delimited path results, and absolute paths will be returned in their full resolved UNC path form, eg insted of 'C:\foo\bar', it will return //?/C:/foo/bar.

Would setting this on the glob avoid all this separator checking / converting in different places in the code?

[wkillerud]

There are a few issues this PR tries to solve:

• The first is that we get different results from Node's path functions on Windows, and we use those to form the input to glob. Here we ensure the input to glob uses forward slashes regardless of OS.
• Another issue is that we use join to form the remote file location (in eik-config.js), which should be with forward slashes.
• A third issue is that the paths in the input (say from eik.json) used as input to Node's path functions don't necessarily match the OS's separators. If config/is/like/this it could perhaps cause issues on Windows 🤔

[wkillerud]

This issue is starting to back up the pull request queues now that they run on Windows hosts. We could skip Windows for now, but it would be nice to get this merged in one state or another.

[github-actions]

🎉 This issue has been resolved in version 4.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀