fix(setup): tighten setup gating and Settings save flow#2
Merged
Conversation
Contributor
Author
|
@ekrist1 Sorry for pinging, but I'm actively using this tool to debug clusters 😅 |
Owner
|
@tharropoulos no problems, happy you find this small cli useful :) Will have a look at the other PR and merge them |
Owner
|
@tharropoulos beta-2 is now released with some small fixes. Thanks for the PR, makes the CLI even more useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.NeedsSetup()and havemain.goenter setup when URL or API key is missingSetupso Settings edits keep non-connection fieldsctrl+cbefore the setup short-circuit so the first-run form is quittable