Get Command and Key for StackExchange.Redis spans by russcam · Pull Request #1374 · elastic/apm-agent-dotnet

russcam · 2021-08-09T07:58:45Z

This commit updates the StackExchange.Redis instrumentation to attempt to
get the redis message command and key for captured DB statements through
reflection, falling back to command in the event reflected properties are not
available.

Closes #1364

This commit updates the StackExchange.Redis instrumentation to attempt to get the redis message command and key for captured DB statements through reflection, falling back to command in the event reflected properties are not available. Closes elastic#1364

ghost · 2021-08-09T08:46:16Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-08-13T06:46:05.492+0000
Duration: 49 min 40 sec
Commit: 349bd6f

Test stats 🧪

Test	Results
Failed	0
Passed	11558
Skipped	119
Total	11677

Trends 🧪

Steps errors

Expand to view the steps failures

`Test & coverage`

Took 3 min 48 sec . View more details on here
Description: .ci/linux/test.sh

`Archive the artifacts`

Took 0 min 0 sec . View more details on here
Description: [2021-08-13T06:58:45.977Z] Archiving artifacts withAzureCredentials: error hudson.AbortException: s

`Error signal`

Took 0 min 0 sec . View more details on here
Description: withAzureCredentials: error hudson.AbortException: script returned exit code 139

Log output

Expand to view the last 100 lines of log output

[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Infrastructure.ObjectResultExecutor[1]
[2021-08-13T07:34:31.943Z]       Executing ObjectResult, writing value of type 'System.String'.
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
[2021-08-13T07:34:31.943Z]       Executed action Elastic.Apm.Tests.MockApmServer.Controllers.IntakeV2EventsController.Post (Elastic.Apm.Tests.MockApmServer) in 2.5554ms
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
[2021-08-13T07:34:31.943Z]       Request finished in 2.8599ms 200 text/plain; charset=utf-8
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
[2021-08-13T07:34:31.943Z]       Request starting HTTP/1.1 POST http://localhost:23820/intake/v2/events application/x-ndjson; charset=utf-8 9269
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[3]
[2021-08-13T07:34:31.943Z]       Route matched with {action = "Post", controller = "IntakeV2Events"}. Executing controller action with signature System.Threading.Tasks.Task`1[Microsoft.AspNetCore.Mvc.IActionResult] Post() on controller Elastic.Apm.Tests.MockApmServer.Controllers.IntakeV2EventsController (Elastic.Apm.Tests.MockApmServer).
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
[2021-08-13T07:34:31.943Z]       Executing action method Elastic.Apm.Tests.MockApmServer.Controllers.IntakeV2EventsController.Post (Elastic.Apm.Tests.MockApmServer) - Validation state: Valid
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
[2021-08-13T07:34:31.943Z]       Executed action method Elastic.Apm.Tests.MockApmServer.Controllers.IntakeV2EventsController.Post (Elastic.Apm.Tests.MockApmServer), returned result Microsoft.AspNetCore.Mvc.OkObjectResult in 3.6549ms.
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Infrastructure.ObjectResultExecutor[1]
[2021-08-13T07:34:31.943Z]       Executing ObjectResult, writing value of type 'System.String'.
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
[2021-08-13T07:34:31.943Z]       Executed action Elastic.Apm.Tests.MockApmServer.Controllers.IntakeV2EventsController.Post (Elastic.Apm.Tests.MockApmServer) in 3.8818ms
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
[2021-08-13T07:34:31.943Z]       Request finished in 4.2002ms 200 text/plain; charset=utf-8
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
[2021-08-13T07:34:31.943Z]       Request starting HTTP/1.1 POST http://localhost:23820/intake/v2/events application/x-ndjson; charset=utf-8 1634
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[3]
[2021-08-13T07:34:31.943Z]       Route matched with {action = "Post", controller = "IntakeV2Events"}. Executing controller action with signature System.Threading.Tasks.Task`1[Microsoft.AspNetCore.Mvc.IActionResult] Post() on controller Elastic.Apm.Tests.MockApmServer.Controllers.IntakeV2EventsController (Elastic.Apm.Tests.MockApmServer).
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
[2021-08-13T07:34:31.943Z]       Executing action method Elastic.Apm.Tests.MockApmServer.Controllers.IntakeV2EventsController.Post (Elastic.Apm.Tests.MockApmServer) - Validation state: Valid
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
[2021-08-13T07:34:31.943Z]       Executed action method Elastic.Apm.Tests.MockApmServer.Controllers.IntakeV2EventsController.Post (Elastic.Apm.Tests.MockApmServer), returned result Microsoft.AspNetCore.Mvc.OkObjectResult in 2.2318ms.
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Infrastructure.ObjectResultExecutor[1]
[2021-08-13T07:34:31.943Z]       Executing ObjectResult, writing value of type 'System.String'.
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
[2021-08-13T07:34:31.943Z]       Executed action Elastic.Apm.Tests.MockApmServer.Controllers.IntakeV2EventsController.Post (Elastic.Apm.Tests.MockApmServer) in 2.4475ms
[2021-08-13T07:34:31.943Z] info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
[2021-08-13T07:34:31.943Z]       Request finished in 2.7061ms 200 text/plain; charset=utf-8
[2021-08-13T07:34:31.944Z] info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
[2021-08-13T07:34:31.944Z]       Request starting HTTP/1.1 GET http://localhost:23820/config/v1/agents?service.name=AspNetFullFramework_Tests_CentralConfigTests-CustomServiceName&service.environment=AspNetFullFramework_Tests_CentralConfigTests-CustomEnvironment  
[2021-08-13T07:34:31.944Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[3]
[2021-08-13T07:34:31.944Z]       Route matched with {action = "Get", controller = "AgentsConfig"}. Executing controller action with signature Microsoft.AspNetCore.Mvc.IActionResult Get() on controller Elastic.Apm.Tests.MockApmServer.Controllers.AgentsConfigController (Elastic.Apm.Tests.MockApmServer).
[2021-08-13T07:34:31.944Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
[2021-08-13T07:34:31.944Z]       Executing action method Elastic.Apm.Tests.MockApmServer.Controllers.AgentsConfigController.Get (Elastic.Apm.Tests.MockApmServer) - Validation state: Valid
[2021-08-13T07:34:31.944Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
[2021-08-13T07:34:31.944Z]       Executed action method Elastic.Apm.Tests.MockApmServer.Controllers.AgentsConfigController.Get (Elastic.Apm.Tests.MockApmServer), returned result Microsoft.AspNetCore.Mvc.StatusCodeResult in 0.0819ms.
[2021-08-13T07:34:31.944Z] info: Microsoft.AspNetCore.Mvc.StatusCodeResult[1]
[2021-08-13T07:34:31.944Z]       Executing HttpStatusCodeResult, setting HTTP status code 304
[2021-08-13T07:34:31.944Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
[2021-08-13T07:34:31.944Z]       Executed action Elastic.Apm.Tests.MockApmServer.Controllers.AgentsConfigController.Get (Elastic.Apm.Tests.MockApmServer) in 0.2006ms
[2021-08-13T07:34:31.944Z] info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
[2021-08-13T07:34:31.944Z]       Request finished in 0.4456ms 304 
[2021-08-13T07:34:32.882Z] info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
[2021-08-13T07:34:32.882Z]       Request starting HTTP/1.1 GET http://localhost:23820/config/v1/agents?service.name=AspNetFullFramework_Tests_CentralConfigTests-CustomServiceName&service.environment=AspNetFullFramework_Tests_CentralConfigTests-CustomEnvironment  
[2021-08-13T07:34:32.882Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[3]
[2021-08-13T07:34:32.882Z]       Route matched with {action = "Get", controller = "AgentsConfig"}. Executing controller action with signature Microsoft.AspNetCore.Mvc.IActionResult Get() on controller Elastic.Apm.Tests.MockApmServer.Controllers.AgentsConfigController (Elastic.Apm.Tests.MockApmServer).
[2021-08-13T07:34:32.882Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
[2021-08-13T07:34:32.882Z]       Executing action method Elastic.Apm.Tests.MockApmServer.Controllers.AgentsConfigController.Get (Elastic.Apm.Tests.MockApmServer) - Validation state: Valid
[2021-08-13T07:34:32.882Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
[2021-08-13T07:34:32.882Z]       Executed action method Elastic.Apm.Tests.MockApmServer.Controllers.AgentsConfigController.Get (Elastic.Apm.Tests.MockApmServer), returned result Microsoft.AspNetCore.Mvc.StatusCodeResult in 0.1132ms.
[2021-08-13T07:34:32.882Z] info: Microsoft.AspNetCore.Mvc.StatusCodeResult[1]
[2021-08-13T07:34:32.882Z]       Executing HttpStatusCodeResult, setting HTTP status code 304
[2021-08-13T07:34:32.882Z] info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
[2021-08-13T07:34:32.882Z]       Executed action Elastic.Apm.Tests.MockApmServer.Controllers.AgentsConfigController.Get (Elastic.Apm.Tests.MockApmServer) in 0.3368ms
[2021-08-13T07:34:32.882Z] info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
[2021-08-13T07:34:32.882Z]       Request finished in 0.6916ms 304 
[2021-08-13T07:34:34.786Z] Elastic APM .NET Tests> 100> Console> [2021-08-13 07:34:34.235 +00:00][Info] - {LoggingTestBase} Finished test: Elastic.Apm.AspNetFullFramework.Tests.CentralConfigTests+MaxSpansAndSampleRateTests.MaxSpans_invalid_value
[2021-08-13T07:34:34.787Z] [xUnit.net 00:18:09.52]   Finished:    Elastic.Apm.AspNetFullFramework.Tests
[2021-08-13T07:34:34.787Z]   Passed Elastic.Apm.AspNetFullFramework.Tests.CentralConfigTests+MaxSpansAndSampleRateTests.MaxSpans_invalid_value [9 s]
[2021-08-13T07:34:34.787Z] 
[2021-08-13T07:34:34.787Z] JunitXML Logger - Results File: C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-1374\apm-agent-dotnet\test\Elastic.Apm.AspNetFullFramework.Tests\junit-NETCoreApp21-Elastic.Apm.AspNetFullFramework.Tests.xml
[2021-08-13T07:34:34.787Z] 
[2021-08-13T07:34:34.787Z] Test Run Successful.
[2021-08-13T07:34:34.787Z] Total tests: 115
[2021-08-13T07:34:34.787Z]      Passed: 115
[2021-08-13T07:34:34.787Z]  Total time: 18.2263 Minutes
[2021-08-13T07:34:34.787Z] 
[2021-08-13T07:34:34.787Z] Build succeeded.
[2021-08-13T07:34:34.787Z]     0 Warning(s)
[2021-08-13T07:34:34.787Z]     0 Error(s)
[2021-08-13T07:34:34.787Z] 
[2021-08-13T07:34:34.787Z] Time Elapsed 00:18:14.52
[2021-08-13T07:34:35.671Z] Post stage
[2021-08-13T07:34:35.685Z] Running in C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-1374\apm-agent-dotnet
[2021-08-13T07:34:35.717Z] Archiving artifacts
[2021-08-13T07:34:36.346Z] Recording test results
[2021-08-13T07:34:38.222Z] [Checks API] No suitable checks publisher found.
[2021-08-13T07:34:38.304Z] Post stage
[2021-08-13T07:34:38.325Z] [WS-CLEANUP] Deleting project workspace...
[2021-08-13T07:34:38.325Z] [WS-CLEANUP] Deferred wipeout is disabled by the job configuration...
[2021-08-13T07:34:43.741Z] [WS-CLEANUP] done
[2021-08-13T07:34:43.917Z] Stage "Release to feedz.io" skipped due to earlier failure(s)
[2021-08-13T07:34:43.960Z] Stage "Release" skipped due to earlier failure(s)
[2021-08-13T07:34:43.979Z] Stage "Release" skipped due to earlier failure(s)
[2021-08-13T07:34:44.019Z] Stage "Release" skipped due to earlier failure(s)
[2021-08-13T07:34:44.086Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-08-13T07:34:44.106Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-08-13T07:34:44.464Z] Running on Jenkins in /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1374
[2021-08-13T07:34:44.519Z] [INFO] getVaultSecret: Getting secrets
[2021-08-13T07:34:44.568Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-08-13T07:34:45.284Z] + chmod 755 generate-build-data.sh
[2021-08-13T07:34:45.284Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/apm-agent-dotnet-mbp/PR-1374/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/apm-agent-dotnet-mbp/PR-1374/runs/3 FAILURE 2919524
[2021-08-13T07:34:45.284Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/apm-agent-dotnet-mbp/PR-1374/runs/3/steps/?limit=10000 -o steps-info.json
[2021-08-13T07:34:45.834Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/apm-agent-dotnet-mbp/PR-1374/runs/3/tests/?status=FAILED -o tests-errors.json

github-actions bot added the agent-dotnet label Aug 9, 2021

russcam added enhancement New feature or request v1.12.0 and removed agent-dotnet labels Aug 9, 2021

russcam mentioned this pull request Aug 9, 2021

[FEATURE] Registering query parameters for 'StackExchange.Redis' spans #1364

Closed

Merge branch 'master' into feature/redis-keys

349bd6f

gregkalapos self-requested a review August 16, 2021 16:59

gregkalapos approved these changes Aug 16, 2021

View reviewed changes

remove blank lines

cf627fa

russcam merged commit 2786029 into elastic:master Aug 17, 2021

russcam added v1.11.0 v1.11.1 and removed v1.12.0 v1.11.0 labels Sep 13, 2021

ededddy mentioned this pull request Jan 12, 2024

[FEATURE] About #1364 and #1374 Gone From the Redis Agent #2252

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get Command and Key for StackExchange.Redis spans#1374

Get Command and Key for StackExchange.Redis spans#1374
russcam merged 3 commits intoelastic:masterfrom
russcam:feature/redis-keys

russcam commented Aug 9, 2021 •

edited by zube bot

Loading

Uh oh!

ghost commented Aug 9, 2021 •

edited by ghost

Loading

Build stats

Test stats 🧪

Trends 🧪

`Test & coverage`

`Archive the artifacts`

`Error signal`

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

russcam commented Aug 9, 2021 • edited by zube bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Aug 9, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Build stats

Test stats 🧪

Trends 🧪

Steps errors

Test & coverage

Archive the artifacts

Error signal

Log output

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

russcam commented Aug 9, 2021 •

edited by zube bot

Loading

ghost commented Aug 9, 2021 •

edited by ghost

Loading

`Test & coverage`

`Archive the artifacts`

`Error signal`