Expose Db and Http on Span.Context via the Public Agent API#149
Merged
gregkalapos merged 3 commits intoelastic:masterfrom Mar 20, 2019
gregkalapos:ExposeSpanContext
Merged
Expose Db and Http on Span.Context via the Public Agent API#149gregkalapos merged 3 commits intoelastic:masterfrom gregkalapos:ExposeSpanContext
gregkalapos merged 3 commits intoelastic:masterfrom
gregkalapos:ExposeSpanContext
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 83.99% 84.74% +0.74%
==========================================
Files 41 45 +4
Lines 1281 1324 +43
Branches 210 216 +6
==========================================
+ Hits 1076 1122 +46
+ Misses 124 121 -3
Partials 81 81
Continue to review full report at Codecov.
|
| [Fact] | ||
| public void FillSpanContext() | ||
| { | ||
|
|
Contributor
There was a problem hiding this comment.
Redundant new line :) ?
SergeyKleyman
approved these changes
Mar 20, 2019
Contributor
Author
|
Retriggering build. Sometimes on Windows the installation of the .net tools seems to fail and our builds fail with |
Contributor
|
It fails to download the dotnet zip file, I'll change the wait it is installed because I found another better, I'd make it when I implemented the upload to NuGet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishing #124.
We already expose
Transaction.Context(and stuff onContext), that was done in #134.In this PR we expose
Span.Context(and stuff on `Context).The approach is the same: as agreed in #124 we simply expose the API defined by the APM Server. No intermediate layer, just a 1-1 mapping of the server json schema to .NET.