Neutral naming for apm-agent-dotnet

[v1v]

What does this pull request do?

Neutral naming

[gregkalapos]

Could we please wait with this until #1605 is merged? I'm doing some work on that PR which is already related to the pipeline. That PR should be done soon.

[gregkalapos]

Could we please wait with this until #1605 is merged? I'm doing some work on that PR which is already related to the pipeline. That PR should be done soon.

Nevermind, it'll take longer - feel free to move on with this.

[gregkalapos]

LGTM.

I see it fails on Linux:

[2022-01-18T18:31:52.016Z] ./build.sh: line 3:  5659 Segmentation fault      dotnet run --project build/scripts -- "$@"
script returned exit code 139

All seems to go ok with it, I don't really get why it segfaults. I tried it locally - all ok.

Update: I re-triggered it, 2. build was fine. I don't know why that happened.

[ghost]

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-01-18T19:28:10.683+0000

• Duration: 91 min 36 sec

• Commit: 73a0849

Test stats 🧪

Test	Results
Failed	2
Passed	19919
Skipped	127
Total	20048

Test errors

Expand to view the tests failures

Initializing / Parallel / Windows .NET Core / Test / ConvenientApiSpanTests.Elastic.Apm.Tests.ApiTests.ConvenientApiSpanTests.AsyncTaskWithReturnTypeAndExceptionAndParameter_OnSubSpan – Elastic.Apm.Tests.ApiTests.ConvenientApiSpanTests

Expand to view the error details

 Expected string to be 
"TestSpan" with a length of 8, but 
"TestSpanType" has a length of 12, differs near "Typ" (index 8). 

Expand to view the stacktrace

 Expected string to be 
"TestSpan" with a length of 8, but 
"TestSpanType" has a length of 12, differs near "Typ" (index 8).
Stack Trace:
   at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
   at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
   at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
   at FluentAssertions.Primitives.StringEqualityValidator.ValidateAgainstLengthDifferences()
   at FluentAssertions.Primitives.StringValidator.Validate()
   at FluentAssertions.Primitives.StringAssertions.Be(String expected, String because, Object[] becauseArgs)
   at Elastic.Apm.Tests.ApiTests.ConvenientApiSpanTests.<AssertWith1TransactionAnd1ErrorAnd1SpanAsyncOnSubSpan>d__43.MoveNext() in C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-1606\apm-agent-dotnet\test\Elastic.Apm.Tests\ApiTests\ConvenientApiSpanTests.cs:line 814
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Elastic.Apm.Tests.ApiTests.ConvenientApiSpanTests.<AsyncTaskWithReturnTypeAndExceptionAndParameter_OnSubSpan>d__33.MoveNext() in C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-1606\apm-agent-dotnet\test\Elastic.Apm.Tests\ApiTests\ConvenientApiSpanTests.cs:line 535
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) 

Initializing / Parallel / Linux / Test / DistributedTracingDataTests.Elastic.Apm.Tests.ApiTests.DistributedTracingDataTests.AsyncTaskWithReturnTypeAndParameter_Invalid(traceId: "00000000000000000000000000000000", parentId: "0000000000000000", traceFlags: "00") – Elastic.Apm.Tests.ApiTests.DistributedTracingDataTests

Expand to view the error details

 System.NullReferenceException : Object reference not set to an instance of an object. 

Expand to view the stacktrace

 System.NullReferenceException : Object reference not set to an instance of an object.
Stack Trace:
   at Elastic.Apm.Tests.ApiTests.DistributedTracingDataTests.AssertInvalidDistributedTracingData(Func`2 transactionCreator, String traceId) in /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1606/apm-agent-dotnet/test/Elastic.Apm.Tests/ApiTests/DistributedTracingDataTests.cs:line 297
   at Elastic.Apm.Tests.ApiTests.DistributedTracingDataTests.AsyncTaskWithReturnTypeAndParameter_Invalid(String traceId, String parentId, String traceFlags) in /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1606/apm-agent-dotnet/test/Elastic.Apm.Tests/ApiTests/DistributedTracingDataTests.cs:line 229
--- End of stack trace from previous location where exception was thrown --- 

Steps errors

Expand to view the steps failures

Build

• Took 1 min 44 sec . View more details here
• Description: .ci/windows/dotnet.bat

Test & coverage

• Took 18 min 28 sec . View more details here
• Description: .ci/windows/test.bat

Archive the artifacts

• Took 0 min 0 sec . View more details here
• Description: [2022-01-18T20:15:34.167Z] Archiving artifacts withAzureCredentials: error hudson.AbortException: s

Error signal

• Took 0 min 0 sec . View more details here
• Description: withAzureCredentials: error hudson.AbortException: script returned exit code 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• run benchmark tests : Run the benchmark test.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)