Auto code cleanup#427
Closed
gregkalapos wants to merge 1 commit intoelastic:masterfrom
gregkalapos:AutoCodeCleanup
Closed
Auto code cleanup#427gregkalapos wants to merge 1 commit intoelastic:masterfrom gregkalapos:AutoCodeCleanup
gregkalapos wants to merge 1 commit intoelastic:masterfrom
gregkalapos:AutoCodeCleanup
Conversation
During reviews I saw an increasing number of code style updates - which is good, we should maintain the coding style as defined in .editorconfig. In order to avoid these in PRs later and making reviews easier I ran auto cleanup on the whole solution. No functional change here - only applied auto clenaup.
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
+ Coverage 79.11% 79.25% +0.14%
==========================================
Files 78 78
Lines 2686 2671 -15
Branches 485 485
==========================================
- Hits 2125 2117 -8
+ Misses 374 369 -5
+ Partials 187 185 -2
Continue to review full report at Codecov.
|
Merged
Contributor
Author
|
Opened #535 - this one is already out-of-date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During reviews I saw an increasing number of code style updates - which is good, we should maintain the coding style as defined in .editorconfig. In order to avoid these in PRs later and making reviews easier I ran auto cleanup on the whole solution.
No functional change here - only applied auto clenaup.
After having a release this week probably this is a good time to do this.
Will try to merge it at a point where there are not much PRs open to minimize conflicts.