Skip to content

Capture body feature#439

Closed
brezaie wants to merge 2 commits intoelastic:masterfrom
brezaie:CaptureBodyFeature
Closed

Capture body feature#439
brezaie wants to merge 2 commits intoelastic:masterfrom
brezaie:CaptureBodyFeature

Conversation

@brezaie
Copy link
Copy Markdown

@brezaie brezaie commented Aug 10, 2019

The CaptureBody feature is added to log the request and response bodies. This feature is boolean, either set to True or False.

Fixed #435

@gregkalapos
Copy link
Copy Markdown
Contributor

Hi @brezaie,

This feature is already implemented in #402. Have you looked at that PR? We already had multiple iterations on it and it's basically just waiting for a last review. Is there anything not covered there?

Given that we already spent a considerable time on #402 I'd keep that.

@brezaie
Copy link
Copy Markdown
Author

brezaie commented Aug 10, 2019

Dear @gregkalapos,
Thanks for your comment. I was wondered if adding the feature takes too long. Thus, I decided to add it sooner to deploy it on our project.

@gregkalapos
Copy link
Copy Markdown
Contributor

The review process is the same for every PR, so #402 is definitely closer to being merged.

@gregkalapos
Copy link
Copy Markdown
Contributor

Hey @brezaie,

#402 got just merged. Would it be ok for you to close this one, since the functionality from this PR is already included on master?

@brezaie
Copy link
Copy Markdown
Author

brezaie commented Aug 17, 2019

Thanks. Yes, I will close it.

@brezaie brezaie closed this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When the request body is added for .net core?

2 participants