Skip to content

Use Implementation-Version as default service version if it is available - #1922

Merged
felixbarny merged 42 commits into
elastic:mainfrom
tobiasstadler:implementation-version
Jan 26, 2022
Merged

Use Implementation-Version as default service version if it is available#1922
felixbarny merged 42 commits into
elastic:mainfrom
tobiasstadler:implementation-version

Conversation

@tobiasstadler

Copy link
Copy Markdown
Contributor

What does this PR do?

When the MANIFEST.MF of main jar contains the Implementation-Version attribute, it is used as the default service version (except for application servers).

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation

@tobiasstadler tobiasstadler changed the title Use Implementation-Version as default version name if it is available Use Implementation-Version as default service version if it is available Jul 16, 2021
@tobiasstadler
tobiasstadler force-pushed the implementation-version branch from cf08453 to 4ac6672 Compare July 16, 2021 07:07
@ghost

ghost commented Jul 16, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-26T16:49:55.428+0000

  • Duration: 54 min 10 sec

  • Commit: 141e256

Test stats 🧪

Test Results
Failed 0
Passed 2449
Skipped 16
Total 2465

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge added the community Issues and PRs created by the community label Jul 27, 2021
@tobiasstadler

Copy link
Copy Markdown
Contributor Author

Could someone please have a look?

@tobiasstadler

Copy link
Copy Markdown
Contributor Author

@SylvainJuge Maybe you can spare some time please

@tobiasstadler

tobiasstadler commented Sep 8, 2021

Copy link
Copy Markdown
Contributor Author

@felixbarny Maybe you can spare some time please?

@AlexanderWert AlexanderWert added this to the 8.0-candidate milestone Sep 13, 2021
@SylvainJuge

Copy link
Copy Markdown
Member

Hi @tobiasstadler, we have added this to our short-term backlog.
While we can't provide guarantees nor ETA, we will try to handle it soon.

@tobiasstadler

Copy link
Copy Markdown
Contributor Author

Thank You! I am looking forward to it.

@tobiasstadler

Copy link
Copy Markdown
Contributor Author

Any chance this will make it into 1.29.0?

@felixbarny felixbarny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement and fits will with the just merged implementation-title detection. Let's refactor the code a bit and I think we're good to go.

@felixbarny felixbarny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to request changes instead of approving.

@tobiasstadler

Copy link
Copy Markdown
Contributor Author

/elasticsearch-ci/docs

@felixbarny felixbarny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to push some polishing changes

@felixbarny
felixbarny enabled auto-merge (squash) January 26, 2022 15:58
@felixbarny

Copy link
Copy Markdown
Member

run elasticsearch-ci/docs

auto-merge was automatically disabled January 26, 2022 16:49

Head branch was pushed to by a user without write access

@tobiasstadler

Copy link
Copy Markdown
Contributor Author

@felixbarny Would you please run elasticsearch-ci/docs again?

@felixbarny

Copy link
Copy Markdown
Member

run elasticsearch-ci/docs

@felixbarny
felixbarny enabled auto-merge (squash) January 26, 2022 17:53
@felixbarny
felixbarny merged commit 0a61bca into elastic:main Jan 26, 2022
@tobiasstadler

Copy link
Copy Markdown
Contributor Author

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java community Issues and PRs created by the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants