Fix log4j init with SecurityManager - #2568
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
| return anchor == null ? LogManager.getContext() : getContext(StackLocatorUtil.getCallerClass(anchor)); | ||
| // the logger context is defined by the class that calls LoggerFactory | ||
| final Class<?> factoryCaller = StackLocatorUtil.getCallerClass(LOGGER_FACTORY); | ||
| if (factoryCaller == null) { | ||
| return LogManager.getContext(); | ||
| } | ||
| return getContext(factoryCaller); |
There was a problem hiding this comment.
@eyalkoren I do need your review on this as I'm not 100% sure it's the right way to fix it.
Without this, the added anonymous class makes loggingLevelChangeTest test fail.
|
/test |
6 participants
What does this PR do?
Relates to #2550
Simply wraps the logger init in a
doPrivilegedblock to get the proper permissions when a Security Manager is present.Moving the
doPrivilegedwrapping down to thegetLoggerorgetContextmethods inLog4jFactoryBridgedoes not work as expected and we get other permission errors with ES, so we keep it in the caller side.Checklist