Skip to content

Security Manager log file fallback - #2581

Merged
SylvainJuge merged 5 commits into
elastic:mainfrom
SylvainJuge:security-manager-log-fallback
Apr 28, 2022
Merged

Security Manager log file fallback#2581
SylvainJuge merged 5 commits into
elastic:mainfrom
SylvainJuge:security-manager-log-fallback

Conversation

@SylvainJuge

@SylvainJuge SylvainJuge commented Apr 12, 2022

Copy link
Copy Markdown
Member

What does this PR do?

When log_file configuration is set, but the configured Security Manager prevents access to the log file (or parent folder), we should properly fallback to using System.out.

Checklist

  • This is a bugfix
    • I have updated CHANGELOG.asciidoc
    • I have added tests that would fail without this fix
    • manually tested with ES integration

@ghost

ghost commented Apr 12, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-28T13:45:10.575+0000

  • Duration: 44 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 2844
Skipped 20
Total 2864

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge
SylvainJuge marked this pull request as ready for review April 25, 2022 09:48
@github-actions

Copy link
Copy Markdown

/test

@SylvainJuge
SylvainJuge enabled auto-merge (squash) April 25, 2022 10:01
@SylvainJuge
SylvainJuge merged commit aa5e406 into elastic:main Apr 28, 2022
@SylvainJuge
SylvainJuge deleted the security-manager-log-fallback branch April 28, 2022 14:31
@SylvainJuge SylvainJuge added await-release Mark issues that depend on next release, or PRs that are planned to be included and removed await-release Mark issues that depend on next release, or PRs that are planned to be included labels May 5, 2022
videnkz pushed a commit to videnkz/apm-agent-java that referenced this pull request May 10, 2022
* add fallback when log not writeable due to SM

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants