Skip to content

Add configuration to suppress Async Profiler logging#3002

Merged
eyalkoren merged 5 commits into
elastic:mainfrom
eyalkoren:asyncprofiler-suppress-logging
Feb 7, 2023
Merged

Add configuration to suppress Async Profiler logging#3002
eyalkoren merged 5 commits into
elastic:mainfrom
eyalkoren:asyncprofiler-suppress-logging

Conversation

@eyalkoren

@eyalkoren eyalkoren commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Closes #1789

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added unit tests that proves the new configuration option is being used where required
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation

@ghost

ghost commented Feb 6, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-02-07T10:39:16.097+0000

  • Duration: 56 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 3484
Skipped 43
Total 3527

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this long-standing issue, I only have one minor suggestion on the option naming.

Have you been able to validate this manually with a JVM that makes async-profiler issue such messages ? I remember some "light" or "small" docker images where those debug symbols were not present, but I can't remember which ones.

@eyalkoren
eyalkoren merged commit 7637d93 into elastic:main Feb 7, 2023
@eyalkoren
eyalkoren deleted the asyncprofiler-suppress-logging branch February 7, 2023 12:54
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WARNING: Install JVM debug symbols to improve profile accuracy

3 participants