Skip to content

Fixed webflux test app tests, reenabled recycling assertion - #3100

Merged
JonasKunz merged 1 commit into
elastic:mainfrom
JonasKunz:reenable_webflux_tests
Apr 13, 2023
Merged

Fixed webflux test app tests, reenabled recycling assertion#3100
JonasKunz merged 1 commit into
elastic:mainfrom
JonasKunz:reenable_webflux_tests

Conversation

@JonasKunz

@JonasKunz JonasKunz commented Apr 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Closes #2967 .

Checklist

JonasKunz
JonasKunz commented Apr 5, 2023
View reviewed changes
Comment thread apm-agent-plugins/apm-spring-webflux/apm-spring-webflux-spring5/pom.xml
<version>${project.version}</version>
</dependency>

<!-- required to test integration with API, for example custom transaction naming -->

@JonasKunz JonasKunz Apr 5, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[For Reviewer]
I think this was a leftover from #1859 , we don't rely on the public API anymore for the tests.

@ghost

ghost commented Apr 5, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-04-12T18:39:13.872+0000

  • Duration: 13 min 21 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@JonasKunz
JonasKunz marked this pull request as ready for review April 6, 2023 09:44
@JonasKunz
JonasKunz requested a review from SylvainJuge April 6, 2023 09:44
@github-actions

github-actions Bot commented Apr 6, 2023

Copy link
Copy Markdown

/test

SylvainJuge
SylvainJuge approved these changes Apr 6, 2023
View reviewed changes

@SylvainJuge SylvainJuge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of those disabled tests !

@JonasKunz
JonasKunz merged commit 4c85b2c into elastic:main Apr 13, 2023
@JonasKunz
JonasKunz deleted the reenable_webflux_tests branch April 13, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SylvainJuge SylvainJuge SylvainJuge approved these changes

Assignees

No one assigned

Labels

agent-java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix and reenable WebFlux tests

3 participants

@JonasKunz @SylvainJuge @elastic-apm-tech