Skip to content

Spring boot integration test upgrade - #3125

Merged
SylvainJuge merged 9 commits into
elastic:mainfrom
JonasKunz:spring-boot-test-upgrade
May 11, 2023
Merged

Spring boot integration test upgrade#3125
SylvainJuge merged 9 commits into
elastic:mainfrom
JonasKunz:spring-boot-test-upgrade

Conversation

@JonasKunz

Copy link
Copy Markdown
Contributor

What does this PR do?

Part of #2942.

  • Adds integration test for spring boot 3
  • Adjusted the RestTemplate test-strategy: The project was upgraded to spring 6 and the integration test is used to test with older versions. This should make it easier to manage upgrades via dependabot.

Checklist

@JonasKunz JonasKunz added the ci:agent-integration Enables agent integration tests in build pipeline label Apr 28, 2023
@ghost

ghost commented Apr 28, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-05-11T10:39:15.465+0000

  • Duration: 15 min 33 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@JonasKunz JonasKunz changed the title Spring boot test upgrade Spring boot integration test upgrade Apr 28, 2023
@JonasKunz
JonasKunz marked this pull request as ready for review April 28, 2023 12:36
@JonasKunz
JonasKunz requested a review from a team April 28, 2023 12:36
@github-actions

Copy link
Copy Markdown

/test

@jabrena

jabrena commented May 5, 2023

Copy link
Copy Markdown

I miss in the integration tests for Spring Boot 3, at least a test using Webclient, right?

@SylvainJuge SylvainJuge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge it.

@SylvainJuge
SylvainJuge merged commit c199404 into elastic:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java ci:agent-integration Enables agent integration tests in build pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants