GH Actions + Buildkite release by reakaleek · Pull Request #3137 · elastic/apm-agent-java

reakaleek · 2023-05-08T13:26:45Z

What does this PR do?

Migrating release pipelines to GH Actions + Buildkite

Based on #3026

github-actions · 2023-05-08T13:27:03Z

👋 @reakaleek Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

ghost · 2023-05-15T11:30:55Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-06-12T11:45:29.835+0000
Duration: 13 min 7 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run benchmark tests : Run the benchmark tests.
run jdk compatibility tests : Run the JDK Compatibility tests.
run integration tests : Run the Agent Integration tests.
run end-to-end tests : Run the APM-ITs.
run windows tests : Build & tests on windows.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Co-authored-by: Jonas Kunz <Jonas.Kunz@gmx.net>

This will be migrated to a updatecli job

reakaleek · 2023-06-05T14:15:32Z

FYI, while renaming the scripts/jenkins folder to scripts/docker-release, I noticed that I was not able to find any usages of ~~check_maven.sh and~~fetch_nexus_id.sh within the repository.

Does anyone know if they are used somewhere else? Is it safe to delete them?

@elastic/observablt-ci @elastic/apm-agent-java

kuisathaverat · 2023-06-06T07:18:46Z

+          java .ci/ReleaseChangelog.java CHANGELOG.asciidoc ${{ inputs.version }}
+          git commit -m "Prepare changelog for release ${{ inputs.version }}" CHANGELOG.asciidoc
+      - name: Bump version and add git tag
+        run: ./mvnw release:prepare -B -DpushChanges=false "-Darguments=-DskipTests -Dmaven.javadoc.skip=true" -DreleaseVersion=${{ inputs.version }}


Commits to the main branch will not be allowed with the new changes in permissions, Would this code work?

I assume it works because the job has

permissions: contents: write

So far the setup has been that the apmmachine-user has the permissions to directly push to the main branch. We implemented this by making apmmachine an admin, while we (the devs) do not have admin permissions.
Will this not work anymore with the permission changes?

It should work, in the github workflow it's the github-action user who will do it and that bot user adheres to the set permissions in the workflow.

On the APM Agent Android, the service account does not have permission to push the main branch. I assume all service accounts will have the same permissions at some point.

cc @cachedout

I've been digging through SLSA requirements this morning and so far I haven't found any explicit provision which says that machine accounts can't commit code. So long as it's a part of a workflow that is initiated by a human, I think this should be OK.

Co-authored-by: Adrien Mannocci <adrien.mannocci@gmail.com>

JonasKunz · 2023-06-12T08:41:30Z

+  provider: "gcp"
+
+steps:
+  - label: "Run the snapshot"


Run the snapshot - is this a copy-paste leftover?

github-actions Bot added agent-java community Issues and PRs created by the community triage labels May 8, 2023

reakaleek self-assigned this May 8, 2023

v1v reviewed May 9, 2023

View reviewed changes

reakaleek force-pushed the feature/release branch from 33be408 to a496660 Compare May 15, 2023 10:49

JonasKunz and others added 7 commits May 15, 2023 13:15

Create GH actions workflow for agent release

e0a54a0

Added missing job dependency

57e0a18

Added another missing dependency

9eb78ab

Add setup-git action and adapt permissions

2414c74

Add docker login

1a00ccb

Replace hardcoded occurrences of main with inputs.branch

4c1baec

Use gh cli instead of custom action

95d27d9

reakaleek force-pushed the feature/release branch from a496660 to 95d27d9 Compare May 15, 2023 11:15

JonasKunz reviewed May 30, 2023

View reviewed changes

Comment thread .github/workflows/release.yml Outdated

reakaleek and others added 4 commits May 31, 2023 15:13

Update .github/workflows/release.yml

9e74b86

Co-authored-by: Jonas Kunz <Jonas.Kunz@gmx.net>

Remove bump_opbeans job

dbef751

This will be migrated to a updatecli job

Remove maven config env

b4d7652

Use input instead of hard coded ref

79e768a

mergify Bot mentioned this pull request May 31, 2023

Test/release migration #3158

Closed

Add buildkite trigger action and complete lambda publish steps

ffb0d16

reakaleek force-pushed the feature/release branch from ea674fb to ffb0d16 Compare June 5, 2023 12:06

reakaleek commented Jun 5, 2023

View reviewed changes

Comment thread .github/workflows/release.yml Outdated

reakaleek added 3 commits June 5, 2023 14:12

Cleanup

57d965c

Checkout tag after it's created by prepare_release

d36f323

Rename scripts/jenkins folder to scripts/docker-release

4791c32

Checkout newly created tag instead of main

9c6fc83

Add notification

9798e9c

reakaleek requested review from a team June 5, 2023 15:54

reakaleek added 2 commits June 5, 2023 18:00

Only allow single workflow at a time

c8b1979

complete needs list

6c4c3a2

reakaleek marked this pull request as ready for review June 5, 2023 16:01

reakaleek requested a review from JonasKunz June 5, 2023 16:01

kuisathaverat reviewed Jun 6, 2023

View reviewed changes

reakaleek requested a review from kuisathaverat June 6, 2023 07:45

reakaleek and others added 2 commits June 6, 2023 10:49

Error if no artifacts our found from buildkite

73d7272

Use correct repo

e6cafa0

amannocci reviewed Jun 7, 2023

View reviewed changes

Comment thread .github/workflows/release.yml Outdated

Comment thread .github/workflows/release.yml

kuisathaverat reviewed Jun 7, 2023

View reviewed changes

Comment thread .github/workflows/release.yml Outdated

reakaleek and others added 2 commits June 7, 2023 11:20

Set permissions on individual jobs

9e66e33

Update .github/workflows/release.yml

90e40ef

Co-authored-by: Adrien Mannocci <adrien.mannocci@gmail.com>

amannocci self-requested a review June 7, 2023 10:08

amannocci approved these changes Jun 7, 2023

View reviewed changes

Remove comment from copy-paste

b5fe13f

kuisathaverat approved these changes Jun 7, 2023

View reviewed changes

JonasKunz approved these changes Jun 12, 2023

View reviewed changes

Fix label

4fbf504

reakaleek enabled auto-merge (squash) June 12, 2023 10:16

reakaleek disabled auto-merge June 12, 2023 10:36

Add default aws region env

a967347

reakaleek enabled auto-merge (squash) June 12, 2023 10:57

reakaleek disabled auto-merge June 12, 2023 11:36

Move benchmarks script to a more appropriate folder

38fe1c4

reakaleek enabled auto-merge (squash) June 12, 2023 11:45

JonasKunz mentioned this pull request Jun 12, 2023

Create GH actions workflow for agent release #3026

Closed

reakaleek merged commit 0c2e1f9 into elastic:main Jun 12, 2023

Uh oh!

Conversation

reakaleek commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

github-actions Bot commented May 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented May 15, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

Uh oh!

Uh oh!

Uh oh!

reakaleek commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kuisathaverat Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

reakaleek Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonasKunz Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

reakaleek Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuisathaverat Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

cachedout Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JonasKunz Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

reakaleek Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

reakaleek commented May 8, 2023 •

edited

Loading

ghost commented May 15, 2023 •

edited by ghost

Loading

reakaleek commented Jun 5, 2023 •

edited

Loading

reakaleek Jun 6, 2023 •

edited

Loading

reakaleek Jun 6, 2023 •

edited

Loading