-
Notifications
You must be signed in to change notification settings - Fork 334
Test with jdk 24 and 25 ea #3949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ba4b80b
Test with jdk 24 ea
JonasKunz af21dee
Merge remote-tracking branch 'elastic/main' into test-java24
JonasKunz 90d99cb
Merge branch 'main' of github.com:elastic/apm-agent-java into test-ja…
SylvainJuge 07efdb3
test with java 24 GA and remove 23
SylvainJuge 5fd986a
update test as 24 has been released
SylvainJuge 71c802a
add java 25 early access as well
SylvainJuge 14faaca
try to remove jacoco
SylvainJuge 1de0e89
Merge branch 'main' of github.com:elastic/apm-agent-java into test-ja…
SylvainJuge 34db676
Merge branch 'main' of github.com:elastic/apm-agent-java into test-ja…
SylvainJuge 1b6259c
Merge branch 'main' of github.com:elastic/apm-agent-java into test-ja…
SylvainJuge 033be97
Merge remote-tracking branch 'elastic/main' into test-java24
JonasKunz f9e2343
Add CheckClassAdapter to analyze bytecode verification erros
JonasKunz 0557761
More logging
JonasKunz 3d46f59
Revert changes tow working state
JonasKunz 6850855
Upgrade junit, disable profiling tests on java 24+
JonasKunz 2d35fd9
Fix lambda tests after JUnit upgrade
JonasKunz 843098c
Update jacoco, add comments and docs
JonasKunz 001531a
Revert unnecessary changes
JonasKunz 3165f59
Move clarification away from experimental note
JonasKunz 39cf111
Add module opens to spring 1.5, must be a side effect of JUnit upgrade
JonasKunz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,7 +116,7 @@ | |
| <!-- -dependencies versions --> | ||
| <version.error_prone>2.2.0</version.error_prone> | ||
| <version.h2>1.4.196</version.h2> | ||
| <version.junit>5.9.1</version.junit> | ||
| <version.junit>5.12.2</version.junit> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. JUnit had to be updated to include the newer java versions in |
||
| <version.junit.vintage>4.13.2</version.junit.vintage> | ||
| <version.okhttp>4.12.0</version.okhttp> | ||
| <!-- this is the last version of slf4j that is compatible with Java 7--> | ||
|
|
@@ -476,6 +476,19 @@ | |
| </executions> | ||
| </plugin> | ||
| <plugin> | ||
| <!-- | ||
| Note that we don't actively use jacoco anymore, but for reasons beyond my understanding the tests will fail if we remove it. | ||
| When removing jacoco, some tests will fail deterministically with a java.lang.VerifyError: null during retransformation | ||
| of the classes under test. I extracted the bytecode from the failed tests and verified it manually using the ASM CheckClassAdapter, | ||
| there the bytecode looks fine and is validated without issues. | ||
| My best guess of an explanation for this behaviour is that we cause some kind of obscure JVM bug during our tests, because | ||
| we continuously retransform classes. This "bug" seems to be prevented by having multiple agents in the JVM (e.g. running the tests | ||
| from IntelliJ with IntelliJ's debug agent also makes them succeed. | ||
| This seems to happen only due to the runtime attachment of the agent in the tests, | ||
| because we have never seen these kinds of problems in production systems. | ||
|
|
||
| So for now I've decided to just let it be and leave jacoco in here. | ||
| --> | ||
| <groupId>org.jacoco</groupId> | ||
| <artifactId>jacoco-maven-plugin</artifactId> | ||
| <configuration> | ||
|
|
@@ -596,7 +609,7 @@ | |
| <plugin> | ||
| <groupId>org.jacoco</groupId> | ||
| <artifactId>jacoco-maven-plugin</artifactId> | ||
| <version>0.8.8</version> | ||
| <version>0.8.13</version> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JUnit upgrade made the lambda tests fail.
They apparently have been relieing on a bug where
static @BeforeAllmethods from subclasses would replacestatic @BeforeAllin parent methods. Now they both execute, causing the tracer to be initialized twice.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's lol