Skip to content

action: edge - #3126

Merged
v1v merged 10 commits into
elastic:mainfrom
v1v:feature/action-edge
Jan 26, 2023
Merged

action: edge#3126
v1v merged 10 commits into
elastic:mainfrom
v1v:feature/action-edge

Conversation

@v1v

@v1v v1v commented Jan 25, 2023

Copy link
Copy Markdown
Member

What

Migrate the edge stage to GitHub actions and will run based on the below events:

  1. merge commits in main
  2. manually

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

Test

See https://github.com/elastic/apm-agent-nodejs/actions/workflows/edge.yml

Follow ups

  • when github command /test-nightly or /test-rc

@github-actions github-actions Bot added the agent-nodejs Make available for APM Agents project planning. label Jan 25, 2023
@v1v

v1v commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

/test-rc

@ghost

ghost commented Jan 25, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-01-26T08:18:19.717+0000

  • Duration: 23 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 323266
Skipped 0
Total 323266

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v

v1v commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

/test-rc

@v1v

v1v commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

/test-rc

@v1v

v1v commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

/test-nightly

@v1v

v1v commented Jan 25, 2023

Copy link
Copy Markdown
Member Author

/test-rc

that's something to e done in a followup
@v1v
v1v requested review from a team January 25, 2023 12:28
@v1v v1v self-assigned this Jan 25, 2023
@v1v v1v added automation Team:Automation Label for the Observability productivity team labels Jan 25, 2023
@v1v v1v mentioned this pull request Jan 25, 2023
8 tasks
@trentm

trentm commented Jan 25, 2023

Copy link
Copy Markdown
Member

@v1v Is there a pattern that other APM projects use for the "/test..." commands for rebuilds that we could follow for consistency? I notice that apm-agent-python, for example uses:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

... plus the `run` `elasticsearch-ci/docs` one that is out of that repo's control

Ah, and Java and others seem to have "/ test" and "run ..." things.

For what it is worth I like the / test [OPTIONS] or / test-OPTION pattern if that is workable. Probably because it hints towards IRC and Slack commands.

@trentm trentm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

Comment thread .github/workflows/edge.yml
Comment thread .github/workflows/edge.yml Outdated
@v1v

v1v commented Jan 26, 2023

Copy link
Copy Markdown
Member Author

@v1v Is there a pattern that other APM projects use for the "/test..." commands for rebuilds that we could follow for consistency?

run ... was the first github command pattern then we moved to
/test ... but kept the run for backward compatibility. Some of those github commands are documented in the oblt-dev repo and https://github.com/elastic/apm-pipeline-library/blob/15602fdc2deeb020c9b67c0ae24bc88f0a2b5fcd/src/co/elastic/NotificationManager.groovy#L491

I think we are in a good position to normalise those names.

OTOH, I tried to configure the github commands within this PR but it seems it won't work until it's available in the default branch :/ For now I'll not implement this now as I'd like to think about your proposal elastic/apm-pipeline-library#1904
so we can use something similar shortly.

Co-authored-by: Trent Mick <trentm@gmail.com>
Comment thread .github/workflows/edge.yml Outdated
Comment thread .github/workflows/edge.yml
@v1v
v1v merged commit 2a30d9c into elastic:main Jan 26, 2023
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-nodejs Make available for APM Agents project planning. automation Team:Automation Label for the Observability productivity team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants