action: lint and ELASTIC_APM_CONTEXT_MANAGER=patch - #3128
Merged
Conversation
v1v
marked this pull request as ready for review
January 25, 2023 14:50
reakaleek
approved these changes
Jan 25, 2023
trentm
requested changes
Jan 26, 2023
trentm
approved these changes
Jan 26, 2023
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate linting and ELASTIC_APM_CONTEXT_MANAGER=patch to GitHub actions
I tried to reuse the same runners by running the same command with the ELASTIC_APM_CONTEXT_MANAGER set as default and patch, but it failed, likely the env context needs to be clean, so it works like a charm by adding the context axis in the matrix.
Checklist