Skip to content

action: lint and ELASTIC_APM_CONTEXT_MANAGER=patch - #3128

Merged
v1v merged 7 commits into
elastic:mainfrom
v1v:feature/ci
Jan 26, 2023
Merged

action: lint and ELASTIC_APM_CONTEXT_MANAGER=patch#3128
v1v merged 7 commits into
elastic:mainfrom
v1v:feature/ci

Conversation

@v1v

@v1v v1v commented Jan 25, 2023

Copy link
Copy Markdown
Member

What

Migrate linting and ELASTIC_APM_CONTEXT_MANAGER=patch to GitHub actions

I tried to reuse the same runners by running the same command with the ELASTIC_APM_CONTEXT_MANAGER set as default and patch, but it failed, likely the env context needs to be clean, so it works like a charm by adding the context axis in the matrix.

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@github-actions github-actions Bot added the agent-nodejs Make available for APM Agents project planning. label Jan 25, 2023
@v1v v1v mentioned this pull request Jan 25, 2023
8 tasks
@ghost

ghost commented Jan 25, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-01-26T09:43:10.961+0000

  • Duration: 18 min 13 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v
v1v requested review from a team January 25, 2023 14:49
@v1v v1v self-assigned this Jan 25, 2023
@v1v v1v added automation Team:Automation Label for the Observability productivity team labels Jan 25, 2023
@v1v
v1v marked this pull request as ready for review January 25, 2023 14:50

@trentm trentm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great.

Comment thread .github/workflows/lint.yml Outdated
Comment thread .github/workflows/test.yml Outdated
Comment thread .github/workflows/test.yml Outdated
@v1v
v1v requested a review from trentm January 26, 2023 09:44
@v1v
v1v merged commit 9ca798e into elastic:main Jan 26, 2023
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-nodejs Make available for APM Agents project planning. automation Team:Automation Label for the Observability productivity team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants