Skip to content

chore: updatecli with dynamic specs - #3845

Merged
v1v merged 5 commits into
mainfrom
feature/updatecli-dynamic
Jan 25, 2024
Merged

chore: updatecli with dynamic specs#3845
v1v merged 5 commits into
mainfrom
feature/updatecli-dynamic

Conversation

@v1v

@v1v v1v commented Jan 25, 2024

Copy link
Copy Markdown
Member

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

What does this PR do?

Test

CI

See https://github.com/elastic/apm-agent-nodejs/actions/runs/7652447333

Locally:

GITHUB_WORKSPACE=/tmp \
  PATH=/opt/homebrew/bin:$PATH \
  GIT_USER="Victor Martinez" \
  GIT_EMAIL="VictorMartinezRubio@gmail.com" \
  GITHUB_TOKEN=$(gh auth token) \
  updatecli apply --config .ci/updatecli/updatecli.d --values .ci/updatecli/values.yml --debug

or without pushing any changes

GITHUB_WORKSPACE=/tmp \
  PATH=/opt/homebrew/bin:$PATH \
  GIT_USER="Victor Martinez" \
  GIT_EMAIL="VictorMartinezRubio@gmail.com" \
  GITHUB_TOKEN=$(gh auth token) \
  updatecli apply --config .ci/updatecli/updatecli.d --values .ci/updatecli/values.yml --push=false --debug

additionally, you can change the org from elastic to your own GitHub avatar.

@github-actions github-actions Bot added the agent-nodejs Make available for APM Agents project planning. label Jan 25, 2024
@v1v
v1v requested review from a team January 25, 2024 09:27
@v1v v1v self-assigned this Jan 25, 2024
@v1v
v1v merged commit 97c9bd4 into main Jan 25, 2024
@v1v
v1v deleted the feature/updatecli-dynamic branch January 25, 2024 20:59
@v1v v1v mentioned this pull request Jul 8, 2024
6 tasks
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants