Add code snippet to fix Asciidoctor link - #923
Merged
Merged
Conversation
bmorelli25
force-pushed
the
fix-asciidoctor-errors
branch
from
March 15, 2019 18:10
12af705 to
87bb27e
Compare
nik9000
approved these changes
Mar 15, 2019
nik9000
left a comment
nik9000
left a comment
Member
There was a problem hiding this comment.
LGTM though I don't know that I'm the right person to review code in this repo.
nik9000
suggested changes
Mar 15, 2019
nik9000
left a comment
nik9000
left a comment
Member
There was a problem hiding this comment.
Actually this doesn't render right for me in Asciidoctor. I think this may be a thing where Asciidoctor and AsciiDoc are just incompatible. i think it is OK because it is fairly rare.
Member
Author
|
Ahh crap you're right. I tested it with asciidoc on accident 🤦♂️ |
Member
Author
|
Alright, just removed the link text. |
watson
approved these changes
Mar 15, 2019
Contributor
|
There seem to be some issues with the tests on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See elastic/docs#724