Skip to content

updatecli: link to the original Pull Request - #1931

Closed
v1v wants to merge 1 commit into
elastic:mainfrom
v1v:feature/use-pr
Closed

updatecli: link to the original Pull Request#1931
v1v wants to merge 1 commit into
elastic:mainfrom
v1v:feature/use-pr

Conversation

@v1v

@v1v v1v commented Nov 7, 2023

Copy link
Copy Markdown
Member

What

Add the original Pull Request that contains the changes in the specs to be in the description of the Pull Request created with the updatecli automation. This will help with track what APM Agents use it.

Test

Given the updatecli and gh cli

When running

$ GIT_USER=foo \
GIT_EMAIL=1 \
GITHUB_TOKEN=*** \
updatecli apply --config .ci/updatecli.d/update-specs.yml --push=false --debug

Then

...
✔ content: found from file "https://github.com/elastic/apm-data/commit/main.patch":
From 5d596b8bb0cbf31aac8ea65e611a8d5d7d5b482d 
...
----
https://github.com/elastic/apm-data/pull/178
----
...

@v1v v1v added the automation label Nov 7, 2023
@v1v
v1v requested review from a team November 7, 2023 12:36
@v1v v1v self-assigned this Nov 7, 2023
@v1v
v1v enabled auto-merge (squash) November 7, 2023 13:28
@v1v

v1v commented Nov 8, 2023

Copy link
Copy Markdown
Member Author

In other words, this change will modify PRs like #1849, that won't contain the link to the commit but also the PR.

image

@v1v

v1v commented Jan 25, 2024

Copy link
Copy Markdown
Member Author

#1957 is the new approach

@v1v v1v closed this Jan 25, 2024
auto-merge was automatically disabled January 25, 2024 09:34

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants