Check for default gemfile instead on bundler directory - #1477
Conversation
|
💚 CLA has been signed |
|
Hi @smedrick thanks for this PR. Did you find this as the result of an error? I just wanted to see if I could reproduce it. Also, if you could sign the CLA, that'd be great. |
I tried to re-run the check and it came back as not signed. Since this PR is over a year old I'm going to close it but can reopen and merge if CLA is detected. |
|
The project went a year without a released change, that's an odd reason to close the PR. Your CLA system is broken and we can't follow your sparse updates without this fix. |
|
@smedrick I was not aware the CLA system is broken. I'm happy to reopen this and help get it resolved. |
|
@smedrick I think the CLA checker might be failing because on https://github.com/elastic/apm-agent-ruby/pull/1477/commits I see that 8acfac1 was authored by "Rick Watkins" (with no contact info) and daf6704 is authored by @smedrick, who does show up in Elastic's internal CLA checker. I think squashing those commits and having only ones authored by @smedrick will make the CLA check pass. If that doesn't work we can try something else. |
Head branch was pushed to by a user without write access
What does this pull request do?
When the stacktrace helper attempts to find the path of installed gems, it uses a method to verify a default bundler install path that attempts to write to the filesystem. This behavior prevents the apm agent from running on a read-only filesystem. This PR attempts to keep the spirit of the functionality while getting around the need to write to the filesystem. Instead of checking if there is a default bundler path, it checks to see if there's a default gemfile.
Why is it important?
Without this bug fix, we cannot run the agent on apps in our secure k8s cluster.
Checklist
.rubocop.yml)Related issues