This repository was archived by the owner on Jan 23, 2024. It is now read-only.
Customise Kibana login with an assistance message#702
Merged
Conversation
kuisathaverat
approved these changes
Dec 26, 2019
mdelapenya
approved these changes
Dec 26, 2019
For some reason the env variables for docker compose don't support the spaces so, let's replace with '\_' as the words separator
Member
Author
|
jenkins run the tests please |
v1v
commented
Jan 9, 2020
| self.environment["ELASTICSEARCH_URL"] = ",".join(self.options.get( | ||
| "kibana_elasticsearch_urls") or [self.DEFAULT_ELASTICSEARCH_HOSTS]) | ||
| if self.at_least_version("7.6") and options.get("xpack_secure"): | ||
| self.environment["XPACK_SECURITY_LOGINASSISTANCEMESSAGE"] = "Login\_details:\_`{}/{}`.\_" \ |
Member
Author
There was a problem hiding this comment.
As I already described in the PR description, there is no other way to customize the login page using the env variables with docker-compose. That's the reason for using the _ as a word separator.
Contributor
There was a problem hiding this comment.
For people who come across this in the future, this is the PR that will eventually fix this in Docker Compose.
kuisathaverat
approved these changes
Jan 9, 2020
mdelapenya
approved these changes
Jan 9, 2020
cachedout
suggested changes
Jan 13, 2020
Contributor
cachedout
left a comment
cachedout
left a comment
There was a problem hiding this comment.
We can work around this by using HTML entity characters to render the spaces correctly in a browser. :)
cachedout
approved these changes
Jan 14, 2020
Contributor
cachedout
left a comment
cachedout
left a comment
There was a problem hiding this comment.
Tested and looks great!!
v1v
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable a customized message on the Kibana login page.
Why is it important?
Help to know the login details easily.
Related issues
Caused by elastic/kibana#51557
Closes #677
Blocked by elastic/kibana#53800
How to test
UI