Skip to content

ci: declare contents:read on test-docs-builder-setup workflow#157

Open
arpitjain099 wants to merge 2 commits into
elastic:mainfrom
arpitjain099:chore/declare-workflow-perms-1778777870-40
Open

ci: declare contents:read on test-docs-builder-setup workflow#157
arpitjain099 wants to merge 2 commits into
elastic:mainfrom
arpitjain099:chore/declare-workflow-perms-1778777870-40

Conversation

@arpitjain099
Copy link
Copy Markdown
Contributor

Adds a workflow-level permissions: contents: read block. The job here only checks out the repository and runs its tests / validation; no GitHub API call beyond the initial checkout is needed.

CVE-2025-30066 (the March 2025 tj-actions/changed-files supply-chain compromise) is the canonical motivation: a tampered third-party action exfiltrated GITHUB_TOKEN from workflow logs and the leaked token retained whatever scope was issued at the workflow level. Per-workflow caps bound that runtime authority irrespective of repo or org default, give drift protection if the default ever widens, and register with OpenSSF Scorecard's Token-Permissions check (which only credits explicit per-workflow declarations).

YAML validated locally with yaml.safe_load.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@arpitjain099 arpitjain099 requested a review from a team as a code owner May 14, 2026 16:58
@arpitjain099 arpitjain099 requested a review from technige May 14, 2026 16:58
@github-actions
Copy link
Copy Markdown

Label error. Requires exactly 1 of: automation, breaking, bug, changelog:skip, chore, ci, dependencies, documentation, enhancement, feature, fix. Found:

@arpitjain099
Copy link
Copy Markdown
Contributor Author

The check-labels job is failing because the PR is missing a required label and external contributors can't add them themselves. Could a maintainer apply chore (or whichever of automation, changelog:skip, or ci fits your conventions better)? Happy to amend the PR body or title if the right label needs that first.

@arpitjain099
Copy link
Copy Markdown
Contributor Author

Friendly bump on this. The PR is blocked on a maintainer applying one of the required labels (automation, breaking, bug, changelog:skip, chore, ci, dependencies, documentation, enhancement, feature, fix). chore would be the right fit for this CI hygiene change.

cc @cotti / @reakaleek / @theletterf, posting since you've been on the recent merge flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant