Add option to include external JAVA_HOME setting for gradle task#65
Merged
Add option to include external JAVA_HOME setting for gradle task#65
Conversation
Member
Author
|
Note that this requires https://github.com/elastic/infra/pull/34352 to be committed first |
Member
Author
|
cc @gtback |
Member
|
Thanks for the ping, @robbavey . I'm fine with these changes; let me know if you need my help with anything. |
karenzone
approved these changes
Jan 25, 2022
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Thanks for making these changes, Rob. LGTM
Member
Author
|
Note for completeness: This commit fixes #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.