Switch APM Server to Asciidoctor - #1083
Merged
Merged
Conversation
Member
Author
|
Sorry, tagged the wrong Nik initially. |
29 tasks
Member
Author
|
Well, dang. The problem is that this shouldn't even be executed. The if should evaluate to false and not display at all. |
This was referenced Aug 19, 2019
Member
|
I talked with Brandon about this and we tracked it down to complex ifevals.
Asciidoctor silently considers then all true. I believe this is a bug that
they fixed in a version after the one we are using!
…On Mon, Aug 19, 2019, 17:14 Brandon Morelli ***@***.***> wrote:
Well, dang.
INFO:build_docs:/tmp/docsbuild/target_repo/html/en/apm/server/7.1/index.xml:1533: element xref: validity error : IDREF attribute linkend references an unknown ID "configuration-autodiscover-hints"
Which is here:
https://github.com/elastic/apm-server/blame/4e817c7da50b58e8a8ba9dbafed4902b3ad3a0b5/docs/copied-from-beats/shared-docker.asciidoc#L198-L217
The problem is that this shouldn't even be executed. The if should
evaluate to false and not display at all.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1083?email_source=notifications&email_token=AABUXIUWFWZZPFO43DJ66LTQFMEJ7A5CNFSM4INGGBS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UKCCA#issuecomment-522756360>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABUXIVTPWQPYRBQ5W3BY3TQFMEJ7ANCNFSM4INGGBSQ>
.
|
This was referenced Aug 20, 2019
Member
Author
|
@elasticmachine, run elasticsearch-ci/docs |
Member
Author
|
New errors below. Chatted with Nik. These are because asciidoctor and asciidoc handle links differently. One uses |
This was referenced Aug 20, 2019
Member
Author
|
@elasticmachine, run elasticsearch-ci/docs |
Member
Author
|
Oooo exciting! Still a lot of PRs to merge that should hopefully reduce the changes. Blocked by:
|
This was referenced Aug 21, 2019
Member
Author
|
@elasticmachine, run elasticsearch-ci/docs |
Member
Author
|
To consolidate things, I'm going to stop posting updates in this PR. All updates will now be in the meta issue: elastic/apm-server#1965. |
Closed
Member
Author
|
@elasticmachine, run elasticsearch-ci/docs |
Member
Author
|
Everything looks ready 🤞. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See elastic/apm-server#1965 for all updates.
📖⛷👨⚕