Adds tech preview macro, updates experimental#2340
Merged
Conversation
gtback
approved these changes
Jan 6, 2022
Member
gtback
left a comment
gtback
left a comment
There was a problem hiding this comment.
LGTM! Just a couple suggestions to keep things clear and tidy 🧹
Contributor
chriscressman
left a comment
chriscressman
left a comment
There was a problem hiding this comment.
LGTM, aside from the issues already raised
Co-authored-by: Greg Back <1045796+gtback@users.noreply.github.com>
Co-authored-by: Greg Back <1045796+gtback@users.noreply.github.com>
jrodewig
approved these changes
Jan 7, 2022
gtback
approved these changes
Jan 10, 2022
Contributor
Author
|
@gtback Hi! The |
Member
|
I'll 🧹 it up, @goodroot ! |
Contributor
Author
|
@gtback Any word? :) We wanna close this out soon. |
Member
|
Sorry, I lost track of this one. I'll take a look now. |
Member
|
@goodroot looks like there was some inconsistency between changes to the admonition text and the strings used in tests. I updated them and hopefully this version will pass. |
Member
|
Finally! @goodroot feel free to merge when you're ready to. |
Contributor
Author
|
Thanks Greg :D I appreciate you. |
v1v
added a commit
to v1v/docs
that referenced
this pull request
Feb 3, 2022
…tral-naming * upstream/master: (28 commits) Fixes .net book generation. (elastic#2367) Add main branch to elasticsearch-net repo to docs build. (elastic#2196) Update attributes.asciidoc (elastic#2365) Note that the full path is required for local doc build (elastic#2364) Bump current version to 7.17 (elastic#2333) moves old file back to bottom add new path for kibana links check apm: Neutral naming for apm-agent-java (elastic#2350) Change current to MS-68 (elastic#2355) Remove unnecessary branch mapping for package-spec (elastic#2359) Adds tech preview macro, updates experimental (elastic#2340) [DOCS] Add `plugins-7x` and `plugins-6x` attributes (elastic#2358) apm: Neutral naming for apm-agent-python (elastic#2348) apm: Neutral naming for apm-agent-rum-js (elastic#2354) apm: Neutral naming for apm-agent-dotnet (elastic#2352) apm: Neutral naming for apm-agent-nodejs (elastic#2353) Neutral naming for apm-agent-go (elastic#2351) apm: Neutral naming for apm-agent-php (elastic#2349) Add 7.last attribute for APM Guide (elastic#2356) [apm] main branch for apm-agent-ruby (elastic#2347) ...
jrodewig
added a commit
that referenced
this pull request
Feb 3, 2022
Updates the old `experimental` admonition to use `preview` text when displayed inline. Relates to #2340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new macro for tech preview, updates old experimental macro to keep them both.
Closes #2305.