Skip to content

Switch the APM Agent for .NET to Asciidoctor - #705

Merged
nik9000 merged 1 commit into
elastic:masterfrom
nik9000:asciidoctor_apm_agent_dotnet
Mar 12, 2019
Merged

Switch the APM Agent for .NET to Asciidoctor#705
nik9000 merged 1 commit into
elastic:masterfrom
nik9000:asciidoctor_apm_agent_dotnet

Conversation

@nik9000

@nik9000 nik9000 commented Mar 12, 2019

Copy link
Copy Markdown
Member

Switches the APM Agent for .NET's docs from the no-longer-maintained
AsciiDoc project to Asciidoctor. The only difference between the html
output is spacing which the browser ignores.

Switches the APM Agent for .NET's docs from the no-longer-maintained
AsciiDoc project to Asciidoctor. The only difference between the html
output is spacing which the browser ignores.
@nik9000 nik9000 mentioned this pull request Mar 12, 2019

@bmorelli25 bmorelli25 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@gregkalapos gregkalapos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Also tested locally, it works fine.
👍

@nik9000
nik9000 merged commit d224c0a into elastic:master Mar 12, 2019
@nik9000

nik9000 commented Mar 12, 2019

Copy link
Copy Markdown
Member Author

Thanks for reviewing @gregkalapos and @bmorelli25!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants