Switch APM Agent for Go to Asciidoctor - #710
Merged
Merged
Conversation
Switches the core of the process that builds the docs for the APM Agent for Go from the no-longer-supports AsciiDoc to the supported Asciidoctor. The html output is slightly different - mostly spacing which is generally ignored by the browser. It *does* change the spacing in front of the go source from a leading eight spaces to a leading tab. These look the same to me in the browser but copy-and-pasting them comes out slightly differently.
Member
Author
|
Here is how the html differs. You can test the change locally using the command in the aliases file. |
Closed
bmorelli25
approved these changes
Mar 12, 2019
7 tasks
axw
approved these changes
Mar 13, 2019
axw
left a comment
axw
left a comment
Contributor
There was a problem hiding this comment.
Tabs is actually better, since that's the standard formatting for Go code. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the core of the process that builds the docs for the APM Agent
for Go from the no-longer-supports AsciiDoc to the supported
Asciidoctor. The html output is slightly different - mostly spacing
which is generally ignored by the browser. It does change the spacing
in front of the go source from a leading eight spaces to a leading tab.
These look the same to me in the browser but copy-and-pasting them comes
out slightly differently.