Skip to content

Switch legacy reporting docs to Asciidoctor - #816

Merged
nik9000 merged 1 commit into
elastic:masterfrom
nik9000:asciidoctor_reporting
Apr 15, 2019
Merged

Switch legacy reporting docs to Asciidoctor#816
nik9000 merged 1 commit into
elastic:masterfrom
nik9000:asciidoctor_reporting

Conversation

@nik9000

@nik9000 nik9000 commented Apr 12, 2019

Copy link
Copy Markdown
Member

Switches the core of the build for the legacy reporting docs from
AsciiDoc to Asciidoctor.

Switches the core of the build for the legacy reporting docs from
AsciiDoc to Asciidoctor.
@nik9000
nik9000 requested a review from lcawl April 12, 2019 17:49

@lcawl lcawl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the output visually and it LGTM, thanks!

@nik9000
nik9000 merged commit 9c3889e into elastic:master Apr 15, 2019
@nik9000

nik9000 commented Apr 15, 2019

Copy link
Copy Markdown
Member Author

Thanks for reviewing @lcawl! I forgot to leave a diff on this one because it was prety much empty iirc.

@nik9000 nik9000 mentioned this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants