Switch Logstash VPR to Asciidoctor - #822
Merged
nik9000 merged 3 commits intoApr 30, 2019
Merged
Conversation
Switches the core of the docs build for the Logstash Versioned Plugin Reference from the unmaintained AsciiDoc project to the actively developed Asciidoctor project.
Member
Author
|
I've created this one as a draft because we'll need some changes before we're ready, but I'd like to make a spot to share the diff. |
Member
Author
|
We're waiting on elastic/logstash-docs#688 and probably a few followup changes before removing "draft" from this PR. |
We don't need edit me links anyway.
nik9000
marked this pull request as ready for review
April 30, 2019 17:30
Member
Author
|
@karenzone I've opened elastic/logstash-docs#691 for something that I saw but at this point the diff looks like a net positive! I'm still going over the diff to see if I see anything, but I think merging this now will fix more things than it breaks. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the core of the docs build for the Logstash Versioned Plugin
Reference from the unmaintained AsciiDoc project to the actively
developed Asciidoctor project.