Skip to content

Monolog 3 Support - #49

Merged
intuibase merged 1 commit into
elastic:mainfrom
segrax:main
Jan 25, 2024
Merged

Monolog 3 Support#49
intuibase merged 1 commit into
elastic:mainfrom
segrax:main

Conversation

@segrax

@segrax segrax commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

Hi,

note: this is BC breaking due to the Monolog change, and should target a v2 release

  • Add support for monolog3
  • Set minimum php version to 8.1
  • Add remaining member/parameter/return types
  • Set BaseType to abstract & implement JsonSerializable
  • Remove redundant type declarations in comments
  • Update to Composer 2.5

@cla-checker-service

cla-checker-service Bot commented Mar 1, 2023

Copy link
Copy Markdown

💚 CLA has been signed

@Nacoma

Nacoma commented Apr 19, 2023

Copy link
Copy Markdown

Lack of monolog v3 support is blocking us from upgrading our systems. Is there an ETA for a new version that supports it?

@georgeconstantinou

Copy link
Copy Markdown

Same here, any plans of merging this MR and tagging a new release?

@sirantd

sirantd commented Apr 25, 2023

Copy link
Copy Markdown

Waiting for it as well

@SergeyKleyman

Copy link
Copy Markdown
Contributor

@segrax First of all thank you very much for your contribution.

My main concern is dropping support for PHP versions before than 8.1. According to the package stats at packagist.org more than 60% of downloads originate from PHP versions below 8.1.

Another concern I have about the PR (which is in a way related to the point above) is the fact that it tries to cover multiple goals. Can the items other than main one (Monolog 3 support) be covered in separate PRs?

It brings me to the following suggestion: if this PR could be limited to just the stated subject (Monolog 3 support) then merging it will become much easier task.

@segrax

segrax commented Apr 28, 2023

Copy link
Copy Markdown
Contributor Author

Hey @SergeyKleyman,

Sure! We can definitely do that.

However, please be aware that the minimum requirement for Monolog 3.0.0 is PHP >= 8.1

@rexs123

rexs123 commented May 23, 2023

Copy link
Copy Markdown

Waiting for this as well, holding us back from upgrading.

@segrax

segrax commented May 24, 2023

Copy link
Copy Markdown
Contributor Author

Hey @SergeyKleyman

Other improvements have been removed, its now just the required changes for Monolog3 support

@sirantd

sirantd commented Jun 1, 2023

Copy link
Copy Markdown

Can anyone take a look at this PR, waiting for it

@JoppeDC

JoppeDC commented Sep 22, 2023

Copy link
Copy Markdown

Can we get an update on this? :)

@njonchee

Copy link
Copy Markdown

We are currently waiting on this

@JoppeDC

JoppeDC commented Jan 12, 2024

Copy link
Copy Markdown

@SergeyKleyman Friendly ping ;)

@SergeyKleyman

Copy link
Copy Markdown
Contributor

@segrax Thank you very much for your effort but after your latest changes the support for both PHP 7.2-80 and Monolog 2.* is dropped. According to Packagist both are still widely used.
One solution I see as possible at the moment is to change ElasticCommonSchemaFormatter in a way that can work with both Monolog 2 and 3.

@segrax

segrax commented Jan 19, 2024

Copy link
Copy Markdown
Contributor Author

@SergeyKleyman Yes, that's right. However, we've assumed that since this library seldom undergoes changes, it wouldn't pose a significant problem. The older versions will remain accessible, and Composer will utilize them according to the PHP version being used.

@intuibase
intuibase merged commit 96aa284 into elastic:main Jan 25, 2024
@hanisko hanisko mentioned this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants