Skip to content

fix: use fromtimestamp instead of deprecated utcfromtimestamp - #105

Merged
basepi merged 2 commits into
elastic:mainfrom
ericdevries:feat/timestamp-deprecation
Dec 7, 2023
Merged

fix: use fromtimestamp instead of deprecated utcfromtimestamp#105
basepi merged 2 commits into
elastic:mainfrom
ericdevries:feat/timestamp-deprecation

Conversation

@ericdevries

Copy link
Copy Markdown
Contributor

Version 3.12 of python deprecated the utcfromtimestamp, this PR uses the correct method.

@cla-checker-service

cla-checker-service Bot commented Dec 6, 2023

Copy link
Copy Markdown

💚 CLA has been signed

Comment thread ecs_logging/__init__.py Outdated
@basepi

basepi commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

This looks great! Just the one requested change and we'll get this merged.

@basepi

basepi commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

@elasticmachine, run elasticsearch-ci/docs

@basepi
basepi enabled auto-merge (squash) December 7, 2023 21:43
@basepi
basepi merged commit 37dcfb0 into elastic:main Dec 7, 2023
@ericdevries
ericdevries deleted the feat/timestamp-deprecation branch December 8, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants