Skip to content

Add official docs - #29

Merged
basepi merged 5 commits into
elastic:masterfrom
basepi:docs
Jan 14, 2021
Merged

Add official docs#29
basepi merged 5 commits into
elastic:masterfrom
basepi:docs

Conversation

@basepi

@basepi basepi commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

Will need to have the docs add these to elastic/docs as well.

Ref #26

@basepi basepi mentioned this pull request Jan 12, 2021
4 tasks
@ghost

ghost commented Jan 12, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #29 updated

    • Start Time: 2021-01-14T04:25:05.018+0000
  • Duration: 7 min 54 sec

  • Commit: 7383073

Test stats 🧪

Test Results
Failed 0
Passed 233
Skipped 8
Total 241

@basepi

basepi commented Jan 14, 2021

Copy link
Copy Markdown
Contributor Author

@bmorelli25 Can you help me get this included in elastic/docs?

@basepi
basepi marked this pull request as ready for review January 14, 2021 00:33
@bmorelli25

Copy link
Copy Markdown
Member

Hi @basepi. Sure! I opened #27 to track all of the pieces.

@bmorelli25

bmorelli25 commented Jan 14, 2021

Copy link
Copy Markdown
Member

elastic/docs PR is up: elastic/docs#2037. This PR needs to be merged first.

I'm assuming you figured this out, as this PR builds without any errors, but others can test with this command:

$GIT_HOME/docs/build_docs --doc $GIT_HOME/ecs-logging-python/docs/index.asciidoc --resource=$GIT_HOME/ecs-logging/docs/ --chunk 1 --open

Comment thread docs/setup.asciidoc Outdated
Comment thread docs/setup.asciidoc
Comment thread .gitignore Outdated
@basepi

basepi commented Jan 14, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for that build command. I mostly stole the template for this from Ruby so I can't take all the credit for it building successfully. :)

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me! :)

Comment thread .gitignore
@basepi
basepi merged commit d667c08 into elastic:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants